Skip to content

Bug/2568 type filter references datafilter with wrong name breaking build dependencies #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoernBerkefeld merged 2 commits into from
Mar 20, 2026
Merged

Bug/2568 type filter references datafilter with wrong name breaking build dependencies #2569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffe1db1
#2568: fix bad reference to dataFilter
JoernBerkefeld Mar 20, 2026
2900768
#0 auto-formatting
JoernBerkefeld Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/Filter.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/definitions/Filter.definition.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/metadataTypes/DataExtensionField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class DataExtensionField extends MetadataType {
.toSorted();
if (removedFieldNames.length > 0) {
Util.logger.warn(
` - dataExtension ${deKey}: found ${removedFieldNames.length} field${removedFieldNames.length>1?'s':''} on the server but not in the deploy payload. Fields cannot be auto-deleted due to potential data loss. To delete them, please run:`
` - dataExtension ${deKey}: found ${removedFieldNames.length} field${removedFieldNames.length > 1 ? 's' : ''} on the server but not in the deploy payload. Fields cannot be auto-deleted due to potential data loss. To delete them, please run:`
);
Util.logger.info(
Util.getGrayMsg(
Expand Down
5 changes: 2 additions & 3 deletions lib/metadataTypes/definitions/Filter.definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default {
'folder-hidden',
],
dependencyGraph: {
filterDefinition: ['r__dataFilter_key'],
dataFilter: ['r__dataFilter_key'],
dataExtension: ['r__source_dataExtension_key', 'r__destination_dataExtension_key'],
},
hasExtended: false,
Expand All @@ -30,8 +30,7 @@ export default {
maxKeyLength: 36, // confirmed max length
type: 'filter',
soapType: 'FilterActivity',
typeDescription:
'Used in automations to filter lists and DEs. Depends on type "FilterDefinitions".',
typeDescription: 'Used in automations to filter lists and DEs. Depends on type "DataFilter".',
typeRetrieveByDefault: true,
typeCdpByDefault: true,
typeName: 'Automation: Filter Activity',
Expand Down
Loading