Skip to content

feature/2519 added previously unsupported asset subtypes (without parsing) #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoernBerkefeld wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feature/2519 added previously unsupported asset subtypes (without parsing) #2520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7359bc9
#2519: added previously unsupported asset subtypes (without parsing)
JoernBerkefeld Feb 27, 2026
33b5253
#2519: adapt response files names for test cases to include new subtypes
JoernBerkefeld Feb 28, 2026
b54ad85
#2519: move jsonmessage into message folder
JoernBerkefeld Mar 4, 2026
e3e2a85
#2519: add asset-cloudpage to types retrieved by default
JoernBerkefeld Mar 6, 2026
64c4c34
Merge branch 'develop' into feature/2519-add-missing-asset-sub-sub-types
JoernBerkefeld Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions @types/lib/metadataTypes/Asset.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion @types/lib/metadataTypes/Asset.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions @types/lib/metadataTypes/definitions/Asset.definition.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 30 additions & 7 deletions lib/metadataTypes/definitions/Asset.definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ export default {
typeDescription: 'Assets from Content Builder grouped into subtypes.',
typeRetrieveByDefault: [
'asset',
'block',
'cloudpage',
'code',
Comment on lines 21 to 25
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typeRetrieveByDefault now includes cloudpage, which changes the behavior of mcdev retrieve asset (it will pull CloudPage assets by default) and will likely break existing expectations/tests that assumed cloudpages were opt-in via asset-cloudpage. If this is not intentional for #2519, remove cloudpage from the default list; otherwise, update tests + PR description to reflect this breaking default-change.

Copilot uses AI. Check for mistakes.
'coderesource',
'textfile',
'block',
'message',
'template',
'other',
'template',
'textfile',
],
typeCdpByDefault: true,
typeName: 'Asset-[Subtype]',
Expand Down Expand Up @@ -548,6 +549,7 @@ export default {
'image',
'message',
'other',
'package',
'rawimage',
'template',
'textfile',
Expand Down Expand Up @@ -576,7 +578,14 @@ export default {
'gpg',
'archive',
],
asset: ['webpage', 'webtemplate', 'jsonmessage', 'icemailformblock', 'asset'],
asset: [
// 1
'webpage',
'webtemplate',
'icemailformblock',
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonmessage (assetTypeId 230) was removed from the asset subtype and added to message. This changes where mobile message assets are retrieved/saved (asset-message instead of asset-asset) and can break dependency caching (e.g. Transactional Push currently depends on asset-asset to resolve r__asset_key). Either keep jsonmessage under asset for backward compatibility, or update dependent metadata definitions/tests to depend on asset-message (and ensure the cache includes 230).

Suggested change
'icemailformblock',
'icemailformblock',
'jsonmessage',

Copilot uses AI. Check for mistakes.
'asset',
],
package: ['packagedefinition', 'packagedeployment'],
audio: [
'aac',
'm4a',
Expand All @@ -596,6 +605,7 @@ export default {
'audio',
],
block: [
// 3
'freeformblock',
'textblock',
'htmlblock',
Expand All @@ -610,6 +620,10 @@ export default {
'buttonblock',
'layoutblock',
'block',
'enhanceddynamicblock',
'iccloudpageblock',
'einsteincontentselectionblock',
'einsteincontenttesting',
],
cloudpage: ['cloudpages', 'landingpage', 'microsite', 'interactivecontent'],
code: [
Expand Down Expand Up @@ -715,7 +729,7 @@ export default {
'svg',
'image',
],
message: ['templatebasedemail', 'htmlemail', 'textonlyemail', 'message'],
message: ['templatebasedemail', 'htmlemail', 'textonlyemail', 'message', 'jsonmessage'],
other: [
'smartcaptureblock',
'smartcaptureformfieldblock',
Expand Down Expand Up @@ -770,7 +784,7 @@ export default {
'x3f',
'rawimage',
],
template: ['defaulttemplate', 'template'],
template: ['defaulttemplate', 'template', 'jsonmessagetemplate', 'jbtemplate'],
textfile: ['text', 'txt', 'textfile'],
video: [
'3gp',
Expand Down Expand Up @@ -1006,6 +1020,7 @@ export default {
dynamicblock: 201,
stylingblock: 202,
einsteincontentblock: 203,
// 204 does not exist
webpage: 205,
webtemplate: 206,
templatebasedemail: 207,
Expand All @@ -1030,8 +1045,16 @@ export default {
liveimageblock: 226,
livesettingblock: 227,
contentmap: 228,
jsonmessage: 230,
enhanceddynamicblock: 229,
jsonmessage: 230, // sms message / whatsapp message based on 235
jbtemplate: 231,
icemailformblock: 232,
iccloudpageblock: 233,
einsteincontentselectionblock: 234,
jsonmessagetemplate: 235, // whatsapp template
packagedefinition: 236,
packagedeployment: 237,
einsteincontenttesting: 238,
coderesource: 239,
jscoderesource: 240,
csscoderesource: 241,
Expand Down
0 ...onse-assetType.idIN1,205,206,230,232.json → ...response-assetType.idIN1,205,206,232.json
View file
Open in desktop
File renamed without changes.
0 ...,228,230,232,240,241,242,243,244,245.json → ...,234,235,238,240,241,242,243,244,245.json
View file
Open in desktop
File renamed without changes.
0 ....idIN223,224,225,226,227,228,230,232.json → ...,227,228,229,231,232,233,234,235,238.json
View file
Open in desktop
File renamed without changes.
0 ...ssetType.idIN225,226,227,228,230,232.json → ...N225,226,227,228,229,232,233,234,238.json
View file
Open in desktop
File renamed without changes.
0 ...,199,200,201,202,203,210,211,212,213.json → ...,203,210,211,212,213,229,233,234,238.json
View file
Open in desktop
File renamed without changes.
0 ...ry/post-response-assetType.idIN4,214.json → ...response-assetType.idIN4,214,231,235.json
View file
Open in desktop
File renamed without changes.
0 ...response-assetType.idIN5,207,208,209.json → ...onse-assetType.idIN5,207,208,209,230.json
View file
Open in desktop
File renamed without changes.
Loading