Merged
Conversation
…due-to-new-createdeltapkg-config Bug/2146 mcdev upgrade fails due to new createdeltapkg config
… project version being higher than app version
…fig-is-on-a-higher-version-that-the-app-it-should-suggest-npm-install-not-npm-update bug/2147 correct prompt to run npm install instead of npm update to fix project version being higher than app version
…ion-of-domainverification feature/2152 allow bulk-creating domainVerifications
…-retrieved-by-default
…d-from-types-retrieved-by-default task/2148 disable retrieving triggeredSend by default as its details reside in journeys
Coverage ReportCommit:3c21452Base: main@5c91609 Details (changed files):
|
Contributor
There was a problem hiding this comment.
PR Overview
This PR prepares the 7.9.0 release by updating various components including metadata bulk creation, utility functions, configuration handling, and tests.
- Added bulk creation support in DomainVerification with a new createRESTBulk method
- Introduced new helper functions in Util and updated CLI/config logic for improved configuration management
- Adjusted test expectations to reflect changes in API call counts
Reviewed Changes
| File | Description |
|---|---|
| lib/metadataTypes/DomainVerification.js | Added bulk creation support and hack for bulk message handling |
| lib/util/util.js | Added deep equality helpers and updated getTypeChoices logic |
| lib/index.js | Updated _reRetrieve signature and logic with an extra parameter |
| lib/util/config.js | Revised upgrade command messages from npm update to npm install |
| lib/util/init.config.js | Improved config update flow and updated _updateLeaf to return boolean |
| lib/metadataTypes/definitions/TriggeredSend.definition.js | Updated description and default flags for triggered send metadata |
| types/mcdev.d.js | Augmented metadata definitions to include bulk creation fields |
| lib/util/cli.js | Removed duplicate subtype summarization helper |
| test/general.test.js | Updated expected API request counts for consistency |
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
lib/metadataTypes/DomainVerification.js:57
- The condition for bulk creation is ambiguous when both 'addresses' and 'deTable/deColumn' are provided; consider clarifying or separating these conditions to ensure the intended behavior.
return metadataItem.domain === 'bulk' && (Array.isArray(metadataItem.addresses) || (metadataItem.deTable && metadataItem.deColumn)) ? this.createRESTBulk(metadataItem, '/messaging/v1/domainverification/') // bulk/insert : super.createREST(metadataItem, '/messaging/v1/domainverification/');
lib/index.js:1033
- [nitpick] Since a new parameter (typeKeyList/defaultPlusTheseTypes) is being passed to _reRetrieve, please update the accompanying JSDoc comment to accurately reflect the function's signature and behavior.
await this._reRetrieve(businessUnit, true, null, typeKeyList);
lib/util/init.config.js:367
- [nitpick] The _updateLeaf function now returns a boolean value indicating if an update occurred; please update its documentation to reflect the new return type.
_updateLeaf(propertiersCur, defaultPropsCur, fieldName) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release details
Checklist
Before merge
npm run prepare-release(which runsnpm audit fix,npm run lint-ts,npm run lint:fix,git add,git commit)After merge
npm run version:major/minor/patchDocumentation
... insert updated documentation here ...
Issues