Skip to content

7.9.0#2154

Merged
JoernBerkefeld merged 14 commits intomainfrom
develop
Mar 7, 2025
Merged

7.9.0#2154
JoernBerkefeld merged 14 commits intomainfrom
develop

Conversation

@JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Mar 7, 2025

Release details

Checklist

Before merge

  • Wiki updated with info in ticket listed under Documentation
  • ran npm run prepare-release (which runs npm audit fix, npm run lint-ts, npm run lint:fix, git add, git commit)
  • pushed potential changes made by prepare-release

After merge

  • merged all dependabot PRs that target main branch
  • updated bug template to include the new version
  • updated .mcdevrc for tests to the new version
  • ran npm run version:major/minor/patch
  • pushed version-prep commits
  • merged main branch into develop branch
  • closed GitHub milestone
  • created new GitHub Release

Documentation

... insert updated documentation here ...

Issues

JoernBerkefeld and others added 13 commits March 6, 2025 13:22
…due-to-new-createdeltapkg-config

Bug/2146 mcdev upgrade fails due to new createdeltapkg config
… project version being higher than app version
…fig-is-on-a-higher-version-that-the-app-it-should-suggest-npm-install-not-npm-update

bug/2147 correct prompt to run npm install instead of npm update to fix project version being higher than app version
…ion-of-domainverification

feature/2152 allow bulk-creating domainVerifications
…d-from-types-retrieved-by-default

task/2148 disable retrieving triggeredSend by default as its details reside in journeys
@JoernBerkefeld JoernBerkefeld added this to the 7.9.0 milestone Mar 7, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 7, 2025
@github-actions
Copy link

github-actions bot commented Mar 7, 2025

Coverage Report

Commit:3c21452
Base: main@5c91609

Type Base This PR
Total Statements Coverage  71.14%  70.9%  (-0.24%)
Total Branches Coverage  70.91%  70.83%  (-0.08%)
Total Functions Coverage  84.15%  83.69%  (-0.46%)
Total Lines Coverage  71.14%  70.9%  (-0.24%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld added bug Something isn't working enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" chore Jira issue-type "Task" c/triggeredSend COMPONENT c/domainVerification labels Mar 7, 2025
@JoernBerkefeld JoernBerkefeld requested a review from Copilot March 7, 2025 13:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR prepares the 7.9.0 release by updating various components including metadata bulk creation, utility functions, configuration handling, and tests.

  • Added bulk creation support in DomainVerification with a new createRESTBulk method
  • Introduced new helper functions in Util and updated CLI/config logic for improved configuration management
  • Adjusted test expectations to reflect changes in API call counts

Reviewed Changes

File Description
lib/metadataTypes/DomainVerification.js Added bulk creation support and hack for bulk message handling
lib/util/util.js Added deep equality helpers and updated getTypeChoices logic
lib/index.js Updated _reRetrieve signature and logic with an extra parameter
lib/util/config.js Revised upgrade command messages from npm update to npm install
lib/util/init.config.js Improved config update flow and updated _updateLeaf to return boolean
lib/metadataTypes/definitions/TriggeredSend.definition.js Updated description and default flags for triggered send metadata
types/mcdev.d.js Augmented metadata definitions to include bulk creation fields
lib/util/cli.js Removed duplicate subtype summarization helper
test/general.test.js Updated expected API request counts for consistency

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

lib/metadataTypes/DomainVerification.js:57

  • The condition for bulk creation is ambiguous when both 'addresses' and 'deTable/deColumn' are provided; consider clarifying or separating these conditions to ensure the intended behavior.
return metadataItem.domain === 'bulk' && (Array.isArray(metadataItem.addresses) || (metadataItem.deTable && metadataItem.deColumn)) ? this.createRESTBulk(metadataItem, '/messaging/v1/domainverification/') // bulk/insert : super.createREST(metadataItem, '/messaging/v1/domainverification/');

lib/index.js:1033

  • [nitpick] Since a new parameter (typeKeyList/defaultPlusTheseTypes) is being passed to _reRetrieve, please update the accompanying JSDoc comment to accurately reflect the function's signature and behavior.
await this._reRetrieve(businessUnit, true, null, typeKeyList);

lib/util/init.config.js:367

  • [nitpick] The _updateLeaf function now returns a boolean value indicating if an update occurred; please update its documentation to reflect the new return type.
    _updateLeaf(propertiersCur, defaultPropsCur, fieldName) {

@JoernBerkefeld JoernBerkefeld merged commit f2d6a1d into main Mar 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c/domainVerification c/triggeredSend COMPONENT chore Jira issue-type "Task" enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"

Projects

None yet

2 participants