Merged
Conversation
…-of-validation-rule-messages Task/2124 improve readability of validation rule messages
…t-get-removed-and-you-re-retrieve-it-by-key-the-actually-deleted-blocks-will-not-be-removed-from-your-disk bug/#1636: locally delete renamed or removed asset parts upon retrieve
…ets-change-the-previous-code-extract-is-not-deleted bug/1232 ensure old asset content blocks get removed if the file type changed
…uld-delete-a-pre-existing-local-file-if-the-key-was-not-found-on-the-server task/1941 delete local file if retrieve-by-key cannot find the item on the server
…ecommended-extensions task/2120 recommend installing mcdev vsce for mcdev projects
…nt-purge-the-deploy-folder-when-no-templates-are-found bug/2119 stop build if buildTemplate did not find any items
…le-to-know-if-a-validationrule-offers-an-automatic-fix task/2131 improve recognition of fixable validation rules
…rule-offers-an-automatic-fix' into develop
Contributor
There was a problem hiding this comment.
PR Overview
This PR prepares the 7.7.2 release by refining error handling, cleanup tasks, and logging consistency across multiple metadata type modules and core utilities. Key changes include:
- Addition of calls to postDeleteTasks in several metadata types when no records are found, ensuring proper cleanup of obsolete files.
- Refactoring of helper functions and options handling (such as in Mcdev.setOptions) to improve robustness and logging.
- Enhancements in Builder and test utilities to better manage key filtering and reset configuration.
Reviewed Changes
| File | Description |
|---|---|
| lib/metadataTypes/MetadataType.js | Updated comments and introduced postUpdateTasks in SOAP updates. |
| lib/metadataTypes/Asset.js | Added postDeleteTasks calls to clean old files during asset retrieval. |
| lib/metadataTypes/DataExtension.js | Adjusted document handling to invoke postDeleteTasks when empty. |
| lib/metadataTypes/Automation.js | Added postDeleteTasks call when no records are found. |
| lib/index.js | Refactored options and buildTemplate logic to check for empty key arrays. |
| lib/util/validations.js | Minor type annotation updates. |
| lib/metadataTypes/ImportFile.js | Added postDeleteTasks call on retrieval failure. |
| lib/metadataTypes/MobileMessage.js | Added cleanup via postDeleteTasks after a 0-record retrieval. |
| lib/metadataTypes/Event.js | Added postDeleteTasks call on 0-record retrieval. |
| lib/metadataTypes/MobileKeyword.js | Added postDeleteTasks call on 0-record retrieval. |
| lib/Builder.js | Implemented removal of keys that caused template build errors. |
| test/utils.js | Updated reset-options logic to derive values from knownOptions. |
| lib/metadataTypes/Journey.js | Minor adjustment to run postDeleteTasks for 'key' mode. |
Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/utils.js:197
- [nitpick] Consider renaming the loop variable 'options' to 'option' since 'handler.knownOptions' is an array; this may improve readability and clarity.
for (const options in handler.knownOptions) {
Coverage ReportCommit:ab5a1caBase: main@cbaaa18
Details (changed files):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release details
Checklist
Before merge
npm run prepare-release(which runsnpm audit fix,npm run lint-ts,npm run lint:fix,git add,git commit)After merge
npm run version:major/minor/patchDocumentation
... insert updated documentation here ...
Issues