Skip to content

Feature/984: bulk update notification email addresses#1066

Open
yuliialikhyt wants to merge 75 commits intodevelopfrom
feature/984-feature-bulk-update-notification-email-addresses
Open

Feature/984: bulk update notification email addresses#1066
yuliialikhyt wants to merge 75 commits intodevelopfrom
feature/984-feature-bulk-update-notification-email-addresses

Conversation

@yuliialikhyt
Copy link
Collaborator

@yuliialikhyt yuliialikhyt commented Aug 3, 2023 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@yuliialikhyt
Copy link
Collaborator Author

yuliialikhyt commented Aug 3, 2023 •
edited
Loading

TODO:

  • Test method
  • function for import file (no endpoint, need to retrieve, update notification email address and re-deploy)
  • check if there are any other types apart for automation and import file where notifications can be set
  • retrieve and update in retrieve + run document to update the .md with notifications. Remove retrieve in test method - it should no longer be necessary
  • some email pre-validation (MC will return "bad payload" if email is not valid)
  • some interactive questions, if someone provided a note but there is no email address, ask if they want to add an email address, otherwise skip the note

JoernBerkefeld
JoernBerkefeld requested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is still in draft but I wanted to give you a few pointers early on :)

@yuliialikhyt yuliialikhyt linked an issue Aug 5, 2023 that may be closed by this pull request
[FEATURE] bulk update notification email addresses #984
Open
@JoernBerkefeld JoernBerkefeld added this to the 5.3.0 milestone Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 13, 2023 •
edited
Loading

Coverage Report

Commit:8e2670a
Base: develop@8e008d3

Type Base This PR
Total Statements Coverage  63.39%  63.69%  (+0.3%)
Total Branches Coverage  67.01%  68.23%  (+1.22%)
Total Functions Coverage  72.14%  72.25%  (+0.11%)
Total Lines Coverage  63.39%  63.69%  (+0.3%)
Details (changed files):
File Statements Branches Functions Lines
lib/cli.js  0%  0%  0%  0%
lib/index.js  69.5%  54.19%  68.57%  69.5%
lib/metadataTypes/Automation.js  81.12%  72.03%  95%  81.12%
lib/metadataTypes/ImportFile.js  82.26%  60%  100%  82.26%
lib/metadataTypes/MetadataType.js  77.32%  72.88%  70%  77.32%
lib/util/cli.js  36.22%  76.92%  23.07%  36.22%
lib/util/util.js  79.64%  75.59%  85.29%  79.64%

@yuliialikhyt
Copy link
Collaborator Author

yuliialikhyt commented Aug 13, 2023 •
edited
Loading

TODO:

  • email validation in interactive questions and in updateNotifications itself
  • a test for importFile updateNotifications, a test for clearNotifications

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Aug 18, 2023

DataVerification activities also have a notification option... but u need to know their id to update them

@yuliialikhyt
Copy link
Collaborator Author

yuliialikhyt commented Aug 20, 2023 •
edited
Loading

DataVerification activities also have a notification option... but u need to know their id to update them

@JoernBerkefeld mcdev does not have data verification as a type yet. I would need to retrieve, then update and deploy like with importFile activity
Maybe in another PR?

@yuliialikhyt yuliialikhyt changed the title Feature/984 feature bulk update notification email addresses Feature/984: bulk update notification email addresses Sep 3, 2023
@yuliialikhyt yuliialikhyt mentioned this pull request Sep 3, 2023
Open
4 tasks
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.2.0, 6.1.0 Sep 22, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.1.0, 6.2.0 May 15, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 7.2.0, 7.3.0 Aug 3, 2024
@JoernBerkefeld
Merge remote-tracking branch 'origin/develop' into feature/984-featur…
427764a 
…e-bulk-update-notification-email-addresses

# Conflicts:
#	.husky/pre-commit
#	docs/dist/documentation.md
#	lib/cli.js
#	lib/index.js
#	lib/metadataTypes/Automation.js
#	lib/metadataTypes/ImportFile.js
#	lib/metadataTypes/MetadataType.js
#	package.json
#	test/resourceFactory.js
#	test/resources/9999999/automation/v1/imports/get-response.json
#	test/resources/9999999/legacy/v1/beta/bulk/automations/automation/definition/get-response.json
#	test/resources/9999999/program/retrieve-response.xml
#	test/type.automation.test.js
#	test/type.importFile.test.js
#	test/type.query.test.js
#	test/type.verification.test.js
@JoernBerkefeld
#984: clean up tests
b056439
@JoernBerkefeld
#984: clean up code
7fe7db2
@JoernBerkefeld JoernBerkefeld modified the milestones: Major 1, 9.1.0 Feb 17, 2026
@JoernBerkefeld
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
80b880e 
…ion-email-addresses

# Conflicts:
#	@types/lib/index.d.ts
#	@types/lib/index.d.ts.map
#	@types/lib/metadataTypes/Automation.d.ts.map
#	@types/lib/metadataTypes/ImportFile.d.ts.map
#	@types/lib/metadataTypes/MetadataType.d.ts.map
#	@types/lib/util/util.d.ts.map
#	lib/index.js
@JoernBerkefeld JoernBerkefeld added the enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" label Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoernBerkefeld JoernBerkefeld Awaiting requested review from JoernBerkefeld

Requested changes must be addressed to merge this pull request.

Assignees

@yuliialikhyt yuliialikhyt

Labels

c/automation COMPONENT c/importFile COMPONENT e/Auditing EPIC enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"

Projects

None yet

Milestone

9.1.0

Development

Successfully merging this pull request may close these issues.

[FEATURE] bulk update notification email addresses

2 participants

@yuliialikhyt @JoernBerkefeld