Skip to content

Update ModelAttributes.cs_Hacktoberfestaccepted #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jammy96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ModelAttributes.cs_Hacktoberfestaccepted #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions Models/Helpers/ModelAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
Expand All @@ -9,31 +9,40 @@ namespace Models.Helpers;
/// This Attribute is used to identify which entities to expose in the API
/// </summary>
[AttributeUsage(AttributeTargets.Class)]
public class ExposeToApi(Type dtoIn, Type dtoOut) : Attribute
public class ExposeToApi : Attribute
{
public Type DtoIn = dtoIn, DtoOut = dtoOut;
public Type DtoIn { get; }
public Type DtoOut { get; }

public ExposeToApi(Type dtoIn, Type dtoOut)
{
DtoIn = dtoIn;
DtoOut = dtoOut;
}
}

public static class IncludedEntities
{
public static IReadOnlyList<(Type, Type, Type)> Types;
//Types are loaded with Lazy<T> to improve performance and resource utilization
private static readonly Lazy<IReadOnlyList<(Type entityType, Type dtoIn, Type dtoOut)>> _types = new Lazy<IReadOnlyList<(Type, Type, Type)>>(LoadTypes);

static IncludedEntities()
public static IReadOnlyList<(Type, Type, Type)> Types => _types.Value;

private static IReadOnlyList<(Type, Type, Type)> LoadTypes()
{
var assembly = typeof(IncludedEntities).GetTypeInfo().Assembly;
var typeList = new List<(Type, Type, Type)>();

//Simplified the attribute fetching using GetCustomAttribute<>() instead of GetCustomAttributes() and checking the length
foreach (var type in assembly.GetLoadableTypes())
{
var attribs = type.GetCustomAttributes(typeof(ExposeToApi), true);
if (attribs.Length > 0)
var attrib = type.GetCustomAttribute<ExposeToApi>();
if (attrib != null)
{
var o = (ExposeToApi)attribs[0];
typeList.Add((type, o.DtoIn, o.DtoOut));
typeList.Add((type, attrib.DtoIn, attrib.DtoOut));
}
}

Types = typeList;
return typeList;
}

public static IEnumerable<Type> GetLoadableTypes(this Assembly assembly)
Expand All @@ -47,4 +56,4 @@ public static IEnumerable<Type> GetLoadableTypes(this Assembly assembly)
return e.Types.Where(t => t != null);
}
}
}
}