fix: update LinkML pin, fix Makefile quoting, regenerate GX artifacts#44
Merged
fix: update LinkML pin, fix Makefile quoting, regenerate GX artifacts#44
Conversation
- Pin linkml to ASCS-eV/linkml@feat/harbour-credentials which includes: - fix(shacl): nodeidentifier range produces sh:BlankNodeOrIRI (PR #3291) - feat(context): --xsd-anyuri-as-iri opt-in flag (PR #3292) - Plus 4 prior fixes for improved SHACL/OWL/context generation - Pin service-characteristics submodule to fix/envited-ontology-fixes - Fix Makefile quoting: quote all $(MAKE) and $(DOMAIN) expansions in case statement bodies to handle paths with spaces/parentheses - Fix update-from-submodule.sh cross-platform issues: - Set MSYS_NO_PATHCONV=1 to prevent Git Bash path conversion - Redirect stderr from merge_schemas.sh to log file (pipe deadlock) - Strip rdfpipe Windows \r Turtle escapes for deterministic output - Regenerate Gaia-X artifacts from service-characteristics@e12e485 Refs: linkml/linkml#3291, linkml/linkml#3292 Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
jdsika
force-pushed
the
fix/update-linkml-pin
branch
from
00a519a to
b3fbfbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the LinkML tooling pin to our patched fork branch (
feat/harbour-credentials),fixes cross-platform Makefile compatibility, and regenerates Gaia-X artifacts.
Changes
LinkML pin update (
pyproject.toml+submodules/linkml)linkml@maintoASCS-eV/linkml@feat/harbour-credentialsMakefile cross-platform fix
$(MAKE)expansions insidecasestatement bodies (25 instances)$(DOMAIN)in argument position$(MAKE)can expand to paths containing spaces and parentheses (e.g.C:/Program Files (x86)/GnuWin32/bin/make), which breaks bashcasesyntax since(is a pattern delimiterupdate-from-submodule.shcross-platform fixes--enum-iri-separator "/"toC:/Program Files/PortableGit/, corrupting all enum IRIs in generated OWL. Fixed by settingMSYS_NO_PATHCONV=1andMSYS2_ARG_CONV_EXCL="*"at the top of the script.merge_schemas.shusesset -exwhich produces verbose trace output on stderr. When invoked through deep process chains (PowerShell → make → sh → bash → bash), the stderr/stdout pipe buffers deadlock on Windows. Fixed by redirecting stderr from generation commands to a log file (.generate-gx.log, already covered by*.login.gitignore).Service-characteristics submodule
fix/envited-ontology-fixesbranch (commit cbb58fe)Regenerated Gaia-X artifacts
artifacts/gx/gx.owl.ttl— regenerated from service-characteristics@cbb58feartifacts/gx/gx.shacl.ttl— regenerated with patched LinkML SHACL generatorartifacts/gx/gx.context.jsonld— regeneratedartifacts/gx/UPSTREAM_COMMIT+UPSTREAM_REF— updated provenanceTesting
make generatesucceeds (openlabel-v2)make generate gxsucceeds (Gaia-X)make testpassesRelated Issues