chore(release): prepare v3.4.0 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Verify.SourceGenerators dependency (lacks net10.0 TFM, caused IDE resolution failures on every restart). Remove 7 redundant tests that were strictly weaker than existing snapshot coverage. Extract shared attributes boilerplate from 72 snapshot files into a single dedicated test, reducing per-snapshot noise by ~108 lines each (-7,823 lines total). Test cleanup: - Remove 3 assertion-only diagnostic tests from ParameterBindingTests (EOE006/EOE010/EOE014 already covered by DiagnosticTests snapshots) - Remove 3 trivial .NotBeEmpty() tests from GeneratorCachingTests - Remove redundant middleware chain test from MiddlewareEmissionTests - Add Generator_Emits_Shared_Attributes_File as single source of truth Dependency updates: - ANcpLua.Roslyn.Utilities 1.28.0 -> 1.30.2 - ANcpLua.NET.Sdk 2.0.0 -> 2.0.4 - Suppress RS1038 in generator project 446 tests pass, 0 failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix unreachable switch arm in Extractor.cs (ReturnsError enum vs int disambiguation now uses TypeKind.Enum check instead of pattern matching) - Add ErrorOrX.Integration.Tests to solution file - Remove phantom EOE055 from CHANGELOG (EOE032 covers it) - Bump version to 3.4.0 - Fix README analyzer count (38 → 41) - Fix CLAUDE.md dependency versions - Generator code cleanup from previous commits Build: 0 warnings, 455 tests pass (446 + 9 integration) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @ANcpLua, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on stabilizing and improving the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
- ANcpLua.Roslyn.Utilities 1.30.2 → 1.31.0 - ANcpLua.Roslyn.Utilities.Testing 1.28.0 → 1.31.0 - ANcpLua.NET.Sdk 2.0.4 → 2.0.5 - Verify.XunitV3 31.9.4 → 31.10.0 - Removed Verify.SourceGenerators (lacks net10.0 TFM) Build: 0 warnings, 455 tests pass Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the v3.4.0 release by addressing a critical bug in Extractor.cs where a switch arm was unreachable, ensuring correct handling of ReturnsErrorAttribute overloads. It also includes substantial code and test suite cleanup, such as removing the Verify.SourceGenerators dependency, simplifying the ParameterSource model, and refactoring tests to be more concise. Dependency versions and documentation have been updated accordingly. The changes are well-executed and improve both the correctness and maintainability of the project. I have one minor suggestion to improve code formatting for better readability.
Comment on lines
72
to
76
| else | ||
| // Simple group without versioning | ||
| // Simple group without versioning | ||
| { | ||
| code.AppendLine($" var {groupVarName} = app.MapGroup(\"{group.GroupPath}\");"); | ||
| } |
There was a problem hiding this comment.
The formatting of this else block is a bit unconventional. The comment // Simple group without versioning seems to apply to the code inside the block, but it's placed outside and at a different indentation level. For better readability and consistency with standard C# formatting, it would be clearer to place the comment inside the block.
else
{
// Simple group without versioning
code.AppendLine($" var {groupVarName} = app.MapGroup(\"{group.GroupPath}\");");
}There was a problem hiding this comment.
Pull request overview
Prepares the v3.4.0 release by bumping versioning, updating docs/changelog, updating dependency pins/SDK versions, tightening generator/test infrastructure (notably snapshot output changes), and ensuring integration tests are included in the solution.
Changes:
- Bump package version to
3.4.0and add3.4.0CHANGELOG entry. - Simplify generator/test setup (exclude shared attributes file from most snapshots; remove
Verify.SourceGeneratorsusage) and apply small generator cleanups. - Update documentation + dependency pins and include
ErrorOrX.Integration.Testsin the solution.
Reviewed changes
Copilot reviewed 95 out of 100 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.props | Bumps VersionPrefix to 3.4.0. |
| tests/ErrorOrX.Generators.Tests/Snapshots/RouteConstraintTests.Supports_Multiple_Constraints.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/RouteConstraintTests.Routes_With_Different_Constraints_Are_Not_Duplicates.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/RouteConstraintTests.CatchAll_Routes_Are_Normalized_Correctly.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/RouteConstraintTests.AsParameters_Constructor_Params_Bind_Route_Parameters.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DuplicateRouteTests.Reports_Duplicate_Route_With_Different_Parameter_Names.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DuplicateRouteTests.Reports_Duplicate_Route_Across_Classes.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.Valid_Service_Type_Inferred.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.Valid_Route_Parameter_Bound.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.Valid_Complex_Type_With_FromBody_On_Post.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.Valid_Complex_Type_With_AsParameters.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE041_No_Diagnostic_When_ProblemDetails_Present.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE041_Missing_ProblemDetails_In_JsonContext.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE039_Validation_Attribute_On_Parameter.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE039_Multiple_Validation_Attributes.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE033_Method_Name_With_Underscore.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE033_Method_Name_Snake_Case.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE033_Method_Name_Lowercase_Start.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE025_With_CamelCase_Policy_No_Diagnostic.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE025_Missing_CamelCase_Policy.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE024_Undocumented_Interface_Call.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE024_Interface_Call_With_ProducesError_No_Diagnostic.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE023_Unknown_Error_Factory.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE022_Too_Many_Result_Types.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE021_Complex_Type_On_Get_Without_Binding.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE021_Complex_Type_On_Delete_Without_Binding.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE020_Int_Constraint_With_String_Parameter.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE020_Guid_Constraint_With_Int_Parameter.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE019_Generic_Type_Parameter.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE018_Private_Return_Type.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE017_Nullable_AsParameters.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE016_Nested_AsParameters.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE015_Anonymous_Return_Type.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE014_Invalid_FromHeader_Type_Complex.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE013_AsParameters_No_Constructor.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE012_Invalid_AsParameters_Type_Primitive.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE011_Invalid_FromQuery_Type_Complex.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE010_Invalid_FromRoute_Type_Complex.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE007_Type_Not_In_Json_Context.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE006_Multiple_Body_Sources_Stream_And_FromBody.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE006_Multiple_Body_Sources_FromBody_And_FromForm.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE005_Unmatched_Close_Brace.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE005_Unclosed_Brace_In_Route.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE005_Empty_Parameter_Name.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE003_Route_Parameter_With_Constraint_Not_Bound.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/DiagnosticTests.EOE003_Route_Parameter_Not_Bound.verified.txt | Snapshot updated (GeneratedSources now empty). |
| tests/ErrorOrX.Generators.Tests/Snapshots/BugRegressionTests.Combined_Local_Variables_In_Route_Group.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/BugRegressionTests.BUG005_Route_Group_With_Valid_Endpoint_Works.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/BugRegressionTests.BUG004_Duplicate_Route_Parameter_Names_First_Wins.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/BugRegressionTests.BUG001_Multiple_Local_Variables_With_Different_Errors.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/BugRegressionTests.BUG001_Local_Variable_Error_Factory_Does_Not_Crash.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.Single_ApiVersion_On_Class_Emits_HasApiVersion.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.No_Versioning_Attributes_Generates_No_Version_Calls.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.Multiple_MapToApiVersion_On_Method_Emits_All_Mappings.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.Multiple_ApiVersions_On_Class_Emits_All_Versions.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.MapToApiVersion_On_Method_Emits_MapToApiVersion.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.Deprecated_ApiVersion_Emits_HasDeprecatedApiVersion.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.ApiVersion_Major_Only_Emits_Single_Parameter_Constructor.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.ApiVersionNeutral_On_Method_Overrides_Class_Version.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.ApiVersionNeutral_On_Class_Emits_IsApiVersionNeutral.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningTests.ApiVersionNeutral_On_Class_Applies_To_All_Methods.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningDiagnosticTests.Valid_ApiVersion_Formats_Do_Not_Report_Diagnostics.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningDiagnosticTests.Multiple_Valid_MapToApiVersion_No_Diagnostics.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningDiagnosticTests.EOE030_No_Diagnostic_When_No_Versioned_Endpoints.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningDiagnosticTests.EOE030_No_Diagnostic_When_ApiVersionNeutral.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningDiagnosticTests.EOE029_ApiVersioning_Package_Not_Referenced_Reports_Warning.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/Snapshots/ApiVersioningDiagnosticTests.ApiVersion_With_Status_Suffix_Is_Valid.verified.txt | Snapshot updated to exclude shared attributes source. |
| tests/ErrorOrX.Generators.Tests/ParameterBindingTests.cs | Removes redundant assertion-style tests (coverage moved to snapshots elsewhere). |
| tests/ErrorOrX.Generators.Tests/ModuleInitializer.cs | Simplifies Verify setup; removes Verify.SourceGenerators initialization. |
| tests/ErrorOrX.Generators.Tests/MiddlewareEmissionTests.cs | Removes a redundant combined-middleware assertion test. |
| tests/ErrorOrX.Generators.Tests/GeneratorTestBase.cs | Filters shared attributes generated file out of Verify snapshots. |
| tests/ErrorOrX.Generators.Tests/GeneratorCachingTests.cs | Adds a dedicated snapshot test for the shared attributes generated file. |
| tests/ErrorOrX.Generators.Tests/ErrorOrX.Generators.Tests.csproj | Drops Verify.SourceGenerators dependency. |
| src/ErrorOrX.Generators/TypeResolution/WellKnownTypes.cs | Removes unused constants / analyzer suppression comments. |
| src/ErrorOrX.Generators/Polyfills.cs | Removes local IDE0130 pragma; suppression moved to .editorconfig. |
| src/ErrorOrX.Generators/OpenApiTransformerGenerator.cs | Minor cleanup in XML doc parsing helper return. |
| src/ErrorOrX.Generators/Models/ParameterSource.cs | Simplifies ParameterSource by removing unused ctor parameters/flags. |
| src/ErrorOrX.Generators/ErrorOrX.Generators.csproj | Documents and suppresses NU5128 + RS1038 for generator/analyzer packaging. |
| src/ErrorOrX.Generators/Emitters/GroupEmitter.cs | Minor formatting/cleanup in group declaration emission. |
| src/ErrorOrX.Generators/Core/ErrorOrEndpointGenerator.ParameterBinding.cs | Cleanup: remove unused placeholders; simplify FromForm classifier signature. |
| src/ErrorOrX.Generators/Core/ErrorOrEndpointGenerator.Emitter.cs | Minor formatting cleanup in emission loops. |
| src/ErrorOrX.Generators/Core/ErrorOrEndpointGenerator.Analyzer.cs | Minor formatting cleanup in analysis loop. |
| src/ErrorOrX.Generators/Analyzers/ErrorOrEndpointAnalyzer.cs | Fixes indentation/bracing for clarity (no behavioral change expected). |
| src/ErrorOrX.Generators/Analyzers/AotSafetyAnalyzer.cs | Removes an unused helper method. |
| samples/DiagnosticsDemos/Demos/EOE001_InvalidReturnType.cs | Minor edits in demo (currently introduces extra blank lines). |
| global.json | Updates ANcpLua MSBuild SDK versions to 2.0.4. |
| README.md | Updates analyzer count from 38 to 41. |
| ErrorOrX.slnx | Adds ErrorOrX.Integration.Tests project to the solution. |
| Directory.Packages.props | Bumps ANcpLua.Roslyn.Utilities to 1.30.2 and removes Verify.SourceGenerators version pin. |
| Directory.Build.props | Updates ANcpLuaRoslynUtilitiesVersion to 1.30.2. |
| CLAUDE.md | Updates documented dependency version for ANcpLua.Roslyn.Utilities. |
| CHANGELOG.md | Adds 3.4.0 release notes; removes phantom EOE055 entry. |
| .editorconfig | Adds generator-specific suppressions (IDE0130 for Polyfills; AL0029 for Extractor). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
37
| return "valid response"; | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
There are two consecutive blank lines inside GetValidSync() after the return statement. This looks accidental and adds noise in the demo file; consider removing the extra empty lines so the method body matches the surrounding style.
Comment on lines
198
to
213
| foreach (var attr in param.GetAttributes()) | ||
| { | ||
| if (attr.AttributeClass is null) | ||
| continue; | ||
|
|
||
| // Check if the attribute inherits from ValidationAttribute | ||
| if (InheritsFrom(attr.AttributeClass, validationAttributeType)) | ||
| { | ||
| context.ReportDiagnostic(Diagnostic.Create( | ||
| Descriptors.ValidationUsesReflection, | ||
| param.Locations.FirstOrDefault() ?? method.Locations.FirstOrDefault(), | ||
| param.Name, | ||
| method.Name)); | ||
| break; // Only report once per parameter | ||
| if (attr.AttributeClass is null) | ||
| continue; | ||
|
|
||
| // Check if the attribute inherits from ValidationAttribute | ||
| if (InheritsFrom(attr.AttributeClass, validationAttributeType)) | ||
| { | ||
| context.ReportDiagnostic(Diagnostic.Create( | ||
| Descriptors.ValidationUsesReflection, | ||
| param.Locations.FirstOrDefault() ?? method.Locations.FirstOrDefault(), | ||
| param.Name, | ||
| method.Name)); | ||
| break; // Only report once per parameter | ||
| } | ||
| } |
There was a problem hiding this comment.
This foreach loop implicitly filters its target sequence - consider filtering the sequence explicitly using '.Where(...)'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extractor.cs—ReturnsError(ErrorType, string)was always falling into the custom error path. Fixed by checkingTypeKind.Enumonargs[0].TypeErrorOrX.Integration.Teststo solution file (was missing, 9 tests not running)Audit
12-agent parallel audit (exodia mega-swarm) found:
Verification
🤖 Generated with Claude Code