Skip to content

Minor code improvements #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martinski4GitHub merged 1 commit into from
Mar 27, 2026
+9 −9
Merged

Minor code improvements #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# uiScribe

## v1.4.13
### Updated on 2026-Mar-02
## v1.4.14
### Updated on 2026-Mar-26

## About
uiScribe updates the System Log page to show log files created by Scribe (syslog-ng). Requires [**Scribe**](https://github.com/cynicastic/scribe)
Expand Down
14 changes: 7 additions & 7 deletions uiScribe.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
## Forked from https://github.com/jackyaz/uiScribe ##
## ##
########################################################
# Last Modified: 2026-Mar-02
# Last Modified: 2026-Mar-26
#-------------------------------------------------------

########### Shellcheck directives ##########
Expand All @@ -29,8 +29,8 @@

### Start of script variables ###
readonly SCRIPT_NAME="uiScribe"
readonly SCRIPT_VERSION="v1.4.13"
readonly SCRIPT_VERSTAG="26030223"
readonly SCRIPT_VERSION="v1.4.14"
readonly SCRIPT_VERSTAG="26032623"
SCRIPT_BRANCH="develop"
SCRIPT_REPO="https://raw.githubusercontent.com/AMTM-OSR/$SCRIPT_NAME/$SCRIPT_BRANCH"
readonly SCRIPT_DIR="/jffs/addons/${SCRIPT_NAME}.d"
Expand Down Expand Up @@ -1506,13 +1506,11 @@ ScriptHeader()
##----------------------------------------##
MainMenu()
{
Create_Dirs
Create_Symlinks
printf " WebUI for %s is available at:\n ${SETTING}%s${CLRct}\n\n" "$SCRIPT_NAME" "$(Get_WebUI_URL)"

printf " ${GRNct}1${CLRct}. Customise list of logs displayed by %s\n\n" "$SCRIPT_NAME"
printf " ${GRNct}rf${CLRct}. Clear user preferences for displayed logs\n\n"
printf " ${GRNct}u${CLRct}. Check for updates\n"
printf " ${GRNct}u${CLRct}. Check for new version updates\n"
printf " ${GRNct}uf${CLRct}. Force update %s with latest version\n\n" "$SCRIPT_NAME"
printf " ${GRNct}e${CLRct}. Exit %s\n\n" "$SCRIPT_NAME"
printf " ${GRNct}z${CLRct}. Uninstall %s\n" "$SCRIPT_NAME"
Expand All @@ -1529,6 +1527,7 @@ MainMenu()
if Check_Lock menu
then
Generate_Log_List
Create_Symlinks
printf "\n"
Clear_Lock
else
Expand Down Expand Up @@ -1858,7 +1857,8 @@ if [ $# -eq 0 ] || [ -z "$1" ]
then
NTP_Ready
Entware_Ready
if grep -qF '/dev/null' "$userCheckLogList"
if [ -s "$userCheckLogList" ] && \
grep -qF '/dev/null' "$userCheckLogList"
then
sed -i '/\/dev\/null/d' "$userCheckLogList"
fi
Expand Down