Skip to content

Fix and Code Improvements#76

Merged
ExtremeFiretop merged 1 commit intoAMTM-OSR:developfrom
Martinski4GitHub:develop
Mar 21, 2026
Merged

Fix and Code Improvements#76
ExtremeFiretop merged 1 commit intoAMTM-OSR:developfrom
Martinski4GitHub:develop

Conversation

@Martinski4GitHub
Copy link
Copy Markdown
Member

  • Removed unnecessary calls to the function that enables/disables the additional WebUI modifications.

  • Modified code to make sure the 'Addons' icon is always added when mounting the WebUI, regardless of whether the extra WebUI modifications are enabled or disabled.

- Removed unnecessary calls to function that handles the additional WebUI modifications.

- Modified code to make sure the 'Addons' icon is always added when mounting the WebUI, regardless of whether the extra WebUI modifications are enabled or disabled.
@Martinski4GitHub Martinski4GitHub requested a review from a team as a code owner March 21, 2026 09:49
Copy link
Copy Markdown
Member Author

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explaining the changes.

@ExtremeFiretop
Copy link
Copy Markdown
Member

Completely approved!!!

And this better helps me understand why the work was being duplicated in some instances.
Nice call @Martinski4GitHub !! Team work makes the dream work!

I think this is finally ready to go out the door, I tested it up and down on both routers without any hickups.
At this point we put it to the wind, and see if anything else blows back at us, production is always the moment of truth!

@ExtremeFiretop ExtremeFiretop merged commit 63f25a0 into AMTM-OSR:develop Mar 21, 2026
1 check passed
@Martinski4GitHub
Copy link
Copy Markdown
Member Author

Completely approved!!!

And this better helps me understand why the work was being duplicated in some instances. Nice call @Martinski4GitHub !! Team work makes the dream work!

I think this is finally ready to go out the door, I tested it up and down on both routers without any hickups. At this point we put it to the wind, and see if anything else blows back at us, production is always the moment of truth!

Agreed. It's now ready for a production release, and we'll see how it behaves in a real user environment, since that's where the rubber meets the road. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants