Quick Cold-Boot Fix

[ExtremeFiretop]

Right now we do this in this order:

1. Extra_WebUI_Modifications apply
2. create/load "$TEMP_MENU_TREE"
3. CreateMenuAddOnsSection
4. mount menuTree.js

That means on a fresh boot, Extra_WebUI_Modifications apply can run before menu_Addons exists in "$TEMP_MENU_TREE",

So .menu_Addons never gets added to /tmp/index_style.css.

Later in the same startup, CreateMenuAddOnsSection adds the Addons menu, but
the CSS decision was already made.

Quick fix is moving: Extra_WebUI_Modifications apply to after "$TEMP_MENU_TREE" has been created and after
CreateMenuAddOnsSection / Sitemap injection has finalized the menu state.

[Martinski4GitHub]

Right now we do this in this order:

1. Extra_WebUI_Modifications apply

2. create/load "$TEMP_MENU_TREE"

3. _CreateMenuAddOnsSection_

4. mount menuTree.js

That means on a fresh boot, Extra_WebUI_Modifications apply can run before menu_Addons exists in "$TEMP_MENU_TREE",

So .menu_Addons never gets added to /tmp/index_style.css.

Later in the same startup, CreateMenuAddOnsSection adds the Addons menu, but the CSS decision was already made.

Quick fix is moving: Extra_WebUI_Modifications apply to after "$TEMP_MENU_TREE" has been created and after CreateMenuAddOnsSection / Sitemap injection has finalized the menu state.

Yeah, the order of execution is critical to make sure the check is done at the right point in the sequence.
Excellent catch, bud!!

[Martinski4GitHub]

Approved the changes!!!

[Martinski4GitHub]

@ExtremeFiretop,

After a closer code review, I found a couple of things that should be changed as well.
I'll submit a separate PR.

[ExtremeFiretop]

Yeah, the order of execution is critical to make sure the check is done at the right point in the sequence. Excellent catch, bud!!

I wont lie, I initially took a bit of a guess where it should go in the Mount_WebUI function, and clearly, I guessed wrong LOL
I didn't put much thought into it initially, I just knew that the Mount_WebUI was the function I was targeting, but once I noticed the bug, it became clear pretty quickly that the order of operations was critical to get it right.