Skip to content

Fix code review issues: missing imports, duplicate lock, and MPI file I/O #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanneshofmann87 merged 2 commits into from
Feb 15, 2026
+13 −9
Merged

Fix code review issues: missing imports, duplicate lock, and MPI file I/O #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
636ee85
Initial plan
Copilot Feb 15, 2026
ea5c9a7
Address code review comments: fix imports, remove duplicate lock, fix…
Copilot Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions Prog/QMC_runtime_var_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
Module QMC_runtime_var

Use runtime_error_mod
Use iso_fortran_env, only: output_unit, error_unit

#ifdef MPI
Use mpi
Expand Down Expand Up @@ -534,7 +535,7 @@ end subroutine set_ham_name
!> ALF-project
!>
!> @brief
!> Bradcast of the QMC runtime variables
!> Broadcast of the QMC runtime variables
!>
!
!--------------------------------------------------------------------
Expand Down Expand Up @@ -582,17 +583,21 @@ subroutine read_and_broadcast_TEMPERING_var()

implicit none

Integer :: ierr
Integer :: ierr, irank

mpi_per_parameter_set = 1 ! Default value
Tempering_calc_det = .true. ! Default value
OPEN(UNIT=5,FILE='parameters',STATUS='old',ACTION='read',IOSTAT=ierr)
IF (ierr /= 0) THEN
WRITE(error_unit,*) 'main: unable to open <parameters>',ierr
CALL Terminate_on_error(ERROR_FILE_NOT_FOUND,__FILE__,__LINE__)

CALL MPI_COMM_RANK(MPI_COMM_WORLD, irank, ierr)
IF (irank == 0) THEN
OPEN(UNIT=5,FILE='parameters',STATUS='old',ACTION='read',IOSTAT=ierr)
IF (ierr /= 0) THEN
WRITE(error_unit,*) 'main: unable to open <parameters>',ierr
CALL Terminate_on_error(ERROR_FILE_NOT_FOUND,__FILE__,__LINE__)
END IF
READ(5,NML=VAR_TEMP)
CLOSE(5)
END IF
READ(5,NML=VAR_TEMP)
CLOSE(5)
CALL MPI_BCAST(N_exchange_steps ,1,MPI_INTEGER,0,MPI_COMM_WORLD,ierr)
CALL MPI_BCAST(N_Tempering_frequency ,1,MPI_INTEGER,0,MPI_COMM_WORLD,ierr)
CALL MPI_BCAST(mpi_per_parameter_set ,1,MPI_INTEGER,0,MPI_COMM_WORLD,ierr)
Expand Down
1 change: 0 additions & 1 deletion Prog/main.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,6 @@ Program Main
else
Call Langevin_HMC%set_Update_scheme(get_Langevin(), get_HMC() )
endif
call lock_QMC_runtime_settings()
Call check_update_schemes_compatibility()

#if defined(MPI)
Expand Down