Add WalletDb Initialization to MempoolNode::new() in src/mempool.rs #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Node::new() function in src/mempool.rs, similar to the WalletDb initialization in src/miner.rs. ONLY WORK ON src/mempool.rs, NO OTHER FILES. DO NOT DELETE ANY CODE OR FILES.
BHouwens
deleted the
feature/add-walletdb-initialization-mempoolnodenew
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Add WalletDb Initialization to MempoolNode
Summary of Changes
This pull request adds a new
WalletDbinitialization to theMempoolNode::new()function insrc/mempool.rs. The implementation mirrors the existingWalletDbinitialization present insrc/miner.rs, ensuring consistent handling of wallet database functionality across the codebase.Motivation
The motivation behind this change is to enhance the
MempoolNodefunctionality by integrating wallet database support, similar to the existing structure inMinerNode. This will provide better resource management and facilitate wallet-related operations within the mempool, contributing to improved overall performance and cohesion of the code.Background Information
The
WalletDbis crucial for managing wallet data effectively. While theMinerNodehas been set up to initialize this component, theMempoolNodelacked this setup, leading to potential inconsistencies and missed opportunities for wallet interactions within the mempool. By unifying the initialization process, we ensure that wallet support is consistently available in both components.Testing Instructions
To test the changes:
MempoolNodeand verify that theWalletDbis properly initialized without any errors.MempoolNodeto confirm that the functionality remains intact and the wallet database operates as expected.Known Issues / Limitations
There are no known issues or limitations at this time. Future improvements may include enhancing the functionality of wallet interactions within the mempool, which can be considered in subsequent updates.
This PR strictly adheres to the user request by only modifying
src/mempool.rs, and no code or files have been deleted or altered beyond the specified changes.