feat(ecosystem): Implement cross-system issue synchronization#14
Open
ShashankFC wants to merge 1 commit into
Open
feat(ecosystem): Implement cross-system issue synchronization#14ShashankFC wants to merge 1 commit into
ShashankFC wants to merge 1 commit into
Conversation
Contributor
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| class AssignmentSource: | ||
| source_name: str | ||
| integration_id: int | ||
| queued: datetime = timezone.now() |
There was a problem hiding this comment.
Dataclass default timezone.now() evaluated once at import time
High Severity
The queued field default timezone.now() is evaluated once when the module is first imported, not each time an AssignmentSource instance is created. Every instance that doesn't explicitly provide queued (including all calls via from_integration) will share the same stale timestamp from server startup. The fix is to use field(default_factory=timezone.now) from dataclasses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Test 7
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.
Replicated from ai-code-review-evaluation/sentry-coderabbit#7
Note
Medium Risk
Touches core assignment and integration sync pathways and changes when outbound sync is suppressed, which could lead to missed assignee updates if source detection/propagation is incorrect.
Overview
Adds an
AssignmentSourcepayload that is threaded through group assignment/deassignment and outbound integration sync tasks to track where an assignment change originated.Updates
IssueSyncIntegration.should_sync(and related call sites) to skip outbound assignee sync when the change source matches the target integration, preventing infinite sync loops while still allowing other integrations to propagate changes. Includes new unit tests forAssignmentSourceserialization and for the cycle-prevention behavior inGroupAssigneeoutbound sync.Written by Cursor Bugbot for commit f9919d7. Configure here.