Replays Self-Serve Bulk Delete System by ShashankFC · Pull Request #16 · AI-Code-Review-Evals/copilot-sentry

ShashankFC · 2026-01-22T15:08:03Z

Test 5

Summary by CodeRabbit

Release Notes

New Features
- Added AI-powered feedback summaries in the feedback list.
- Introduced table widget visualization for dashboards with customizable columns.
- Added owner assignment support for workflow detectors.
- Enhanced replay summaries with error context integration.
Bug Fixes
- Improved PR comment formatting with better issue title and environment display.
- Refined feedback summary generation with stricter length and format constraints.
- Disabled autofix automation tuning by default for improved stability.

Replicated from ai-code-review-evaluation/sentry-coderabbit#5

This validates both the [Working Draft](https://www.w3.org/TR/reporting-1/#concept-reports) and the [Editor's Draft](https://w3c.github.io/reporting/#concept-reports) formats. Fixes [ID-730 - Accept current and upcoming data model](https://linear.app/getsentry/issue/ID-730/accept-current-and-upcoming-data-model).

…3936)

…o 'low' (#93927)" This reverts commit 8d04522. Co-authored-by: roaga <47861399+roaga@users.noreply.github.com>

Missed in the initial commit, leading to some relevant logs being unannotated.

We have had a few tasks get killed at 10% rollout.

Also add a test, so that this doesn't happen again

Fixes DE-129 and DE-156 --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>

These transitions should be matching

…` (#93946) Use `project_id` on the replay record instead of the URL (where it does not always exist). --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Also fixed `replay.view_html` -> `replay.view-html` --------- Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>

…948) gets `npx @typescript/native-preview` passing again

This adds mode for all things tracing. This encompasses transactions/metrics/spans. Taken from https://github.com/getsentry/sentry/blob/feeaf393deeca8b97675bff23039c6320270aab5/src/sentry/runner/commands/devserver.py#L370

The conditions associated with a DCG can change over time, and it's good if we can be completely confident that they're consistent within a given task execution.

This is unused and most regex experiments have required broader changes to ensure that regexes are evaluated in a specific order (ex: traceparent). Removing this for now to simplify the code and very slightly improve runtime performance.

relates to https://linear.app/getsentry/issue/REPLAY-418/add-error-and-user-feedback-context-to-llm

From some testing (on feedback lists of all different lengths), this prompt seems to work better. It doesn't write overly long sentences and also does a better job at "summarizing" versus just mentioning a few specific topics and leaving out others.

Just remove a couple custom Flex* classes in favor of the Flex primitive

This has been killed a few times. Refs SENTRY-42M7

…n table (#93892)  [ticket](https://linear.app/getsentry/issue/ID-156/grouping-info-remove-type-field-from-ui) The Type field in the Grouping Info section of the issue details page was redundant. This removes the Type row from all variant types while keeping the underlying data structure intact. before ![Screenshot 2025-06-20 at 12 00 54 PM](https://github.com/user-attachments/assets/97ca72da-0a52-4446-9825-cd4fcb505adf) after ![Screenshot 2025-06-20 at 11 59 29 AM](https://github.com/user-attachments/assets/a4284d2b-c9f5-442f-b010-7fe72a598e39)

### Changes Related to this PR: getsentry/sentry#93810. This is part 1 of the change, which is pulling out the new component and just adding it to the repo. Also includes some simplification of the logic in the base component. Part 2 will be replacing tables in widgets. ### Before/After There is no UI change as the table is not being used yet. There is a new story page for the component.

…93943) to prevent this issue from becoming too noisy, add a noise config

Unfortunately, 'event_data' went from being the variable for current event context to being the complete parsed data from Redis, and we continued logging it per group. That's more data than we should be logging even arguably once, let alone per group.

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>

Adds some simple analytics to our endpoint so we can begin building a dashboard in Amplitude.

Previously, explore supported multiple y axis per chart, so each visualize supported multiple y axis. That functionality has since been removed for simplicity so update the types here to match. Keep in mind that saved queries still store them as an array so when serializing/deserializing, we still need to treat it as an array.

We'll need the `useGetTraceItemAttributeKeys` hook in other places so refactoring it so that it can exported.

- getsentry/sentry#93894 removed usage - getsentry/sentry-options-automator#4243 removed the last override

When the max segment ID is null the process fails. We should exit early since if there aren't any segments to delete there's nothing to do.

Copilot

Pull request overview

This PR implements several enhancements across the codebase, including improvements to workflow engine processing, detector owner assignment, replay error context integration, and various UI/UX refinements.

Changes:

Enhanced workflow engine to optimize slow condition queries and improve logging
Added owner assignment support for detectors with validation for users and teams
Integrated error context into replay summaries for better debugging insights
Refactored multiple components to use standardized Flex layout component
Updated default autofix automation tuning from "low" to "off"

Reviewed changes

Copilot reviewed 106 out of 106 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/sentry/workflow_engine/processors/delayed_workflow.py	Optimized slow condition query handling by pre-fetching and logging missing conditions
src/sentry/workflow_engine/endpoints/validators/base/detector.py	Added owner field validation and persistence for detector creation/updates
src/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py	Integrated error event details into replay breadcrumb summaries
tests/sentry/workflow_engine/processors/test_delayed_workflow.py	Updated tests to pass dcg_to_slow_conditions parameter
tests/sentry/replays/test_project_replay_summarize_breadcrumbs.py	Added comprehensive tests for error context integration
static/app/views/explore/*	Refactored visualization handling from arrays to single yAxis field
src/sentry/projectoptions/defaults.py	Changed default autofix automation tuning to "off"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-30T10:33:00Z

  toJSON(): BaseVisualize {
    const json: BaseVisualize = {
-      yAxes: this.yAxes,
+      yAxes: [this.yAxis],


The toJSON method converts a single yAxis back to an array format (yAxes), while the constructor accepts a single yAxis string. This mismatch creates confusion and could lead to bugs when serializing/deserializing. Consider either keeping the internal representation as an array or updating toJSON to match the constructor's expectations.

Copilot · 2026-01-30T10:33:00Z

+  static fromJSON(json: BaseVisualize): Visualize[] {
+    return json.yAxes.map(
+      yAxis => new Visualize(yAxis, {label: '', chartType: json.chartType})
+    );


The fromJSON method now returns an array of Visualize objects instead of a single instance, which is a breaking change to the API. This inconsistency with the toJSON method (which returns BaseVisualize with yAxes array) could cause confusion. Consider documenting this behavior or ensuring calling code handles the array return type correctly.

Copilot · 2026-01-30T10:33:01Z

+                message=data.get("message", ""),
+            )
+            for event_id, data in zip(error_ids, events.values())
+            if data is not None


The code assumes that all values in events.values() are dictionaries with the expected keys. If nodestore returns data in an unexpected format or if required fields are missing, this could raise KeyError or return incorrect data. Add validation to ensure data is a dictionary before accessing keys.

Suggested change

if data is not None

if isinstance(data, dict)

Copilot · 2026-01-30T10:33:01Z

+            # Check if we need to yield any error messages that occurred before this event
+            while error_idx < len(error_events) and error_events[error_idx][
+                "timestamp"
+            ] < event.get("timestamp", 0):
+                error = error_events[error_idx]
+                yield generate_error_log_message(error)
+                error_idx += 1


Using event.get("timestamp", 0) could cause incorrect chronological ordering if events legitimately have a timestamp of 0 or if the timestamp is missing. This could result in errors being inserted at the wrong position in the log sequence. Consider using a more robust default or validating that timestamp exists.

Suggested change

# Check if we need to yield any error messages that occurred before this event

while error_idx < len(error_events) and error_events[error_idx][

"timestamp"

] < event.get("timestamp", 0):

error = error_events[error_idx]

yield generate_error_log_message(error)

error_idx += 1

# Check if we need to yield any error messages that occurred before this event.

# Do not use a default timestamp value, as that can mis-order events when the

# timestamp is missing.

event_ts = event.get("timestamp")

if event_ts is not None:

while error_idx < len(error_events) and error_events[error_idx]["timestamp"] < event_ts:

error = error_events[error_idx]

yield generate_error_log_message(error)

error_idx += 1

Copilot · 2026-01-30T10:33:01Z

@@ -68,7 +67,7 @@ export function useAddToDashboard() {
        query: search.formatString(),
        version: 2,
        dataset,


The yAxis is converted back to an array format here for the EventView, which creates inconsistency with the new single yAxis approach used throughout the codebase. This suggests the refactoring may not be complete or that EventView requires array format. Consider documenting why this conversion is necessary or updating EventView to accept single yAxis.

Suggested change

dataset,

dataset,

// Explore uses a single yAxis value, but EventView/NewQuery still expects an array.

// Wrap the single yAxis to satisfy the EventView API without changing Explore's model.

Copilot · 2026-01-30T10:33:02Z

    feedbacks,
 ):
-    feedbacks_string = "\n".join(f"- {msg}" for msg in feedbacks)
+    feedbacks_string = "\n------\n".join(feedbacks)


The separator ------ is a magic string that could be extracted as a named constant for better maintainability and to make its purpose clearer.

armenzg and others added 30 commits June 20, 2025 12:49

fix(insights): adds referrer to Insights charts create alerts url (#9…

ba199fa

…3936)

Revert "chore(autofix): Change default automation tuning from 'off' t…

668229d

…o 'low' (#93927)" This reverts commit 8d04522. Co-authored-by: roaga <47861399+roaga@users.noreply.github.com>

fix(aci): Use contextual logger in workflow processor (#93947)

a6e22c7

Missed in the initial commit, leading to some relevant logs being unannotated.

fix(taskworker) Increase deadlines for webhook delivery (#93941)

4549d79

We have had a few tasks get killed at 10% rollout.

fix(ourlogs): Fix top events for logs (#93939)

1a81517

Also add a test, so that this doesn't happen again

feat(aci): Set ownership on detector (#93745)

37375d9

Update RightMask component background gradient (#93933)

976bb0b

Fixes DE-129 and DE-156 --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>

button: fix transition (#93934)

d088de3

These transitions should be matching

fix(migrations): Patch broken saved search migrations (#93944)

8a179d9

feat(replay): Add analytics to timeline zoom buttons (#93910)

a37f99f

Also fixed `replay.view_html` -> `replay.view-html` --------- Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>

ref(profiling): Move flamegraphFrameFilter types around for tsgo (#93…

38d4d58

…948) gets `npx @typescript/native-preview` passing again

feat(devservices): Add tracing mode (#93759)

78d346e

This adds mode for all things tracing. This encompasses transactions/metrics/spans. Taken from https://github.com/getsentry/sentry/blob/feeaf393deeca8b97675bff23039c6320270aab5/src/sentry/runner/commands/devserver.py#L370

feat(feedback): frontend to display summary (#93567)

5cc91e0

fix(aci): Ensure slow conditions are consistent (#93895)

084b63a

The conditions associated with a DCG can change over time, and it's good if we can be completely confident that they're consistent within a given task execution.

ref(replay): include error context in breadcrumb summary (#93669)

8167cc5

relates to https://linear.app/getsentry/issue/REPLAY-418/add-error-and-user-feedback-context-to-llm

✨ feat(scm): add environment infomation to suspect commit prs (#93025)

fd4ab7b

flex: cleanup Flex* custom styling in favor of Flex primitive (#93809)

31c51d5

Just remove a couple custom Flex* classes in favor of the Flex primitive

fix(taskworker) Extend deadlines for check_auth (#93961)

b4d3000

This has been killed a few times. Refs SENTRY-42M7

feat(detectors): Add noise config to DB Query Injection Issue Type (#…

2e992ba

…93943) to prevent this issue from becoming too noisy, add a noise config

feat(trace-eap-waterfall): Hiding some attrs (#93964)

de377a6

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>

feat(preprod): Add analytics to the assemble endpoint (#93871)

786861a

Adds some simple analytics to our endpoint so we can begin building a dashboard in Amplitude.

ref(trace-items): Pull useGetTraceItemAttributeKeys into hook (#93739)

9f84049

We'll need the `useGetTraceItemAttributeKeys` hook in other places so refactoring it so that it can exported.

mrduncan and others added 2 commits June 20, 2025 13:20

chore(issues): Remove traceparent experiment (#93942)

c9fee3f

- getsentry/sentry#93894 removed usage - getsentry/sentry-options-automator#4243 removed the last override

fix(replay): Add handling for null max_segment_id (#93989)

ea188e2

When the max segment ID is null the process fails. We should exit early since if there aren't any segments to delete there's nothing to do.

ShashankFC requested a review from Copilot January 30, 2026 10:31

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replays Self-Serve Bulk Delete System#16

Replays Self-Serve Bulk Delete System#16
ShashankFC wants to merge 32 commits into
replays-delete-vulnerablefrom
replays-delete-stable

ShashankFC commented Jan 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

ShashankFC commented Jan 22, 2026

Summary by CodeRabbit

Release Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants