scale-color $lightness must use $secondary for dark themes#7
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d38c4d5f74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| a { | ||
| font-weight: bold; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 70%), scale-color($secondary, $lightness: 30%)); |
There was a problem hiding this comment.
In light theme, dark-light-choose uses its first argument, so this change now renders topic meta links with scale-color($primary, $lightness: 70%) instead of the previous 30%. That makes the link text much lighter in the light theme, which is a regression unrelated to the dark-theme swap and can reduce readability. Consider keeping the original light-theme value and only switching the dark-theme branch to $secondary.
Useful? React with 👍 / 👎.
| .custom-message-length { | ||
| margin: -10px 0 10px 20px; | ||
| color: scale-color($primary, $lightness: 70%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 30%), scale-color($secondary, $lightness: 70%)); | ||
| font-size: 85%; |
There was a problem hiding this comment.
Because dark-light-choose selects the first argument in light mode, this change makes .custom-message-length use scale-color($primary, $lightness: 30%) where it previously used 70%. That substantially darkens the hint text in the light theme and is inconsistent with the stated goal of only adjusting dark-theme colors. Keep the original light-theme value and only update the dark-theme branch.
Useful? React with 👍 / 👎.
| h3 { | ||
| margin-bottom: 4px; | ||
| margin-top: 0; | ||
| color: scale-color($primary, $lightness: 20%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); | ||
| line-height: 23px; |
There was a problem hiding this comment.
In light mode, this now uses scale-color($primary, $lightness: 50%) instead of the previous 20%, so the topic map heading becomes much lighter and less prominent in the light theme. That appears to be an accidental regression while adding dark-theme support. The first argument should stay at the original 20% and only the dark-theme branch should switch to $secondary.
Useful? React with 👍 / 👎.
3 participants
Test 7
Replicated from ai-code-review-evaluation/discourse-cursor#7