UX: show complete URL path if website domain is same as instance domain#6
UX: show complete URL path if website domain is same as instance domain#6ShashankFC wants to merge 1 commit into
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 267d8be1f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def include_website_name | ||
| website.present? |
There was a problem hiding this comment.
include_website_name only checks website.present?, so for TL0 users viewed by anonymous (where restrict_user_fields? hides website via untrusted_attributes), website_name is still serialized and the profile template will render it. That leaks the website host/path that the privacy filter is meant to suppress. Consider applying the same restrict_user_fields? check (or reusing the include_website? logic) so website_name is omitted whenever website is omitted.
Useful? React with 👍 / 👎.
3 participants
Test 6
Replicated from ai-code-review-evaluation/discourse-cursor#6