Optimize header layout performance with flexbox mixins#5
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b229316ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .panel { | ||
| float: right; | ||
| position: relative; | ||
| margin-left: auto; | ||
|
|
||
| @include order(3); |
There was a problem hiding this comment.
In the noscript header (app/views/application/_header.html.erb lines 3–18), .panel sits inside a .row, and .row is still the Bootstrap float-based grid (app/assets/stylesheets/vendor/bootstrap.scss lines 25–38), not a flex container. After removing float: right here, the login panel will no longer align to the right and will stack below the title when JavaScript is disabled (the <noscript> path). Keeping the float for that markup or making .row a flex container would avoid the regression in no-JS environments.
Useful? React with 👍 / 👎.
2 participants
Test 5
Replicated from ai-code-review-evaluation/discourse-cursor#5