FEATURE: per-topic unsubscribe option in emails#2
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6669a2d94d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.route('fromParamsNear', { path: '/:nearPost' }); | ||
| }); | ||
| this.resource('topicBySlug', { path: '/t/:slug' }); | ||
| this.route('topicUnsubscribe', { path: '/t/:slug/:id/unsubscribe' }); |
There was a problem hiding this comment.
Align route name with template path
The new route is registered as top‑level topicUnsubscribe, which Ember resolves to the topic-unsubscribe template/controller/view. However the template added in this commit lives at app/assets/javascripts/discourse/templates/topic/unsubscribe.hbs, which corresponds to a nested topic.unsubscribe route. Unless this route is moved under the topic resource (or the template is renamed/moved to topic-unsubscribe.hbs), the unsubscribe page will render without its intended template.
Useful? React with 👍 / 👎.
Test 2
Replicated from ai-code-review-evaluation/discourse-cursor#2