fix: handle collective multiple host on destinationCalendar#3
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd797c1ea0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const [mainHostDestinationCalendar] = evt.destinationCalendar ?? []; | ||
| if (evt.location === MeetLocationType && mainHostDestinationCalendar.integration !== "google_calendar") { |
There was a problem hiding this comment.
When evt.destinationCalendar is null or [] (e.g., several callers now pass []), destructuring yields undefined and mainHostDestinationCalendar.integration throws, so MeetLocationType bookings without a destination calendar crash before event creation. This used to be protected by optional chaining on destinationCalendar, so it’s a regression for events that don’t specify a destination calendar. Consider using mainHostDestinationCalendar?.integration or guarding for empty arrays.
Useful? React with 👍 / 👎.
| const selectedCalendar = externalCalendarId | ||
| ? externalCalendarId | ||
| : event.destinationCalendar?.externalId; | ||
| : event.destinationCalendar?.find((cal) => cal.externalId === externalCalendarId)?.externalId; |
There was a problem hiding this comment.
If externalCalendarId is missing (which can happen for older booking references), the fallback find(... === externalCalendarId) compares against undefined, so selectedCalendar becomes undefined and calendar.events.update is called with calendarId: undefined. Google rejects that request, so updates can fail for those bookings. Previously this defaulted to the destination calendar’s externalId; you likely need a real fallback (destination calendar or primary).
Useful? React with 👍 / 👎.
| const selectedCalendar = calEventRaw.destinationCalendar?.find( | ||
| (cal) => cal.credentialId === credentialId | ||
| )?.externalId; |
There was a problem hiding this comment.
Calendar selection now only matches by credentialId. For legacy DestinationCalendar rows that have externalId but no credentialId, selectedCalendar becomes undefined and inserts into "primary". In the no-credentialId branch of createAllCalendarEvents, that means events are created on every credential’s primary instead of the intended externalId, producing duplicates and wrong placement. Consider falling back to the destination calendar’s externalId when no credentialId is present.
Useful? React with 👍 / 👎.
3 participants
Test 4nn---nReplicated from ai-code-review-evaluation/cal.com-cursor#4