-
Notifications
You must be signed in to change notification settings - Fork 0
Nieuwe help voor PISS en certficering #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds extensive new help documentation for AFAS partner certification and the AppConnector Auditor tool. The documentation is provided in both Dutch and English, with separate versions for partners (stricter certification requirements) and developers (more flexible guidelines).
Changes:
- Added comprehensive partner certification steps with phased approach (Start, Build, Deliver)
- Created new AppConnector Auditor documentation split by audience (Partner vs Developer reports)
- Added partner data administration documentation explaining certification status and requirements
- Updated existing partner documentation with better structure, new sections, and improved cross-references
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
markdownpages/profit/nl/partner-certification-steps.md |
Updated Dutch certification guide with phased structure and improved formatting |
markdownpages/profit/nl/app-connector-auditor-partnergegevens.md |
New Dutch documentation for partner administrative data and integration status |
markdownpages/profit/nl/app-connector-auditor-partner.md |
Major update to Dutch partner report with detailed error/warning explanations |
markdownpages/profit/nl/app-connector-auditor-developer.md |
New Dutch developer-focused auditor documentation with less strict requirements |
markdownpages/profit/en/partner-certification-steps.md |
Updated English certification guide matching Dutch version structure |
markdownpages/profit/en/app-connector-auditor-partnerinfo.md |
New English documentation for partner information and integrations |
markdownpages/profit/en/app-connector-auditor-partner.md |
Major update to English partner report with comprehensive certification criteria |
markdownpages/profit/en/app-connector-auditor-developer.md |
New English developer-focused auditor documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### Supplying GetConnectors | ||
| --- | ||
|
|
||
| ### Suppl GetConnectors |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text states "Suppl GetConnectors" which appears to be incomplete. This should be "Supply GetConnectors" or "Supplying GetConnectors".
| ### Suppl GetConnectors | |
| ### Supplying GetConnectors |
|
|
||
| Deze help is bedoeld als **naslagwerk en technische specificatie**, niet als vervanging van persoonlijk overleg. | ||
|
|
||
| Dit document is nooit af. Zie je iets dat niet klopt, of heb je suggesties voor verbetering? Maak een pull request aan op de [GitHub-pagina van de documentatie](https://github.com/AFASSoftware/OASContent/blob/main/markdownpages/profit/nl/app-connector-auditor-partner.md). |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub link points to "app-connector-auditor-partner.md" but this is the developer documentation file. The link should point to "app-connector-auditor-developer.md" to match the current file.
| Dit document is nooit af. Zie je iets dat niet klopt, of heb je suggesties voor verbetering? Maak een pull request aan op de [GitHub-pagina van de documentatie](https://github.com/AFASSoftware/OASContent/blob/main/markdownpages/profit/nl/app-connector-auditor-partner.md). | |
| Dit document is nooit af. Zie je iets dat niet klopt, of heb je suggesties voor verbetering? Maak een pull request aan op de [GitHub-pagina van de documentatie](https://github.com/AFASSoftware/OASContent/blob/main/markdownpages/profit/nl/app-connector-auditor-developer.md). |
|
|
||
| ### Security check | ||
|
|
||
| Veiligheid voor alles! Een pentest is een absoluut onmisbaar onderdeel van de certficering. Bij aanvang van het certificeringstraject moet er een pentest gedaan zijn, of er moet een concrete datum ingepland zijn. Zorg er bij voorkeur voor dat de pentest wordt uitgevoerd door een [CCV-erkende partij](https://hetccv.nl/certificaat-schema/pentesten). |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: "certficering" should be "certificering".
| Veiligheid voor alles! Een pentest is een absoluut onmisbaar onderdeel van de certficering. Bij aanvang van het certificeringstraject moet er een pentest gedaan zijn, of er moet een concrete datum ingepland zijn. Zorg er bij voorkeur voor dat de pentest wordt uitgevoerd door een [CCV-erkende partij](https://hetccv.nl/certificaat-schema/pentesten). | |
| Veiligheid voor alles! Een pentest is een absoluut onmisbaar onderdeel van de certificering. Bij aanvang van het certificeringstraject moet er een pentest gedaan zijn, of er moet een concrete datum ingepland zijn. Zorg er bij voorkeur voor dat de pentest wordt uitgevoerd door een [CCV-erkende partij](https://hetccv.nl/certificaat-schema/pentesten). |
| date: 2026-01-25 | ||
| index: true | ||
| tags: Partner, Administratie, Certificering, Partnergegevens | ||
| title: Partnergegevens en koppelingen |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title tag in the English version is "Partnergegevens en koppelingen" (Dutch) but should be "Partner information and integrations" (English) to match the document heading and maintain consistency.
| title: Partnergegevens en koppelingen | |
| title: Partner information and integrations |
| author: Eric Zwaal | ||
| date: 2026-01-25 | ||
| index: true | ||
| tags: Partner, Administratie, Certificering, Partnergegevens |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tags field contains "Administratie" which is Dutch. Since this is the English version of the document, the tags should be in English. Consider replacing "Administratie" with "Administration" and "Certificering" with "Certification".
| tags: Partner, Administratie, Certificering, Partnergegevens | |
| tags: Partner, Administration, Certification, Partner information |
|
|
||
| ## Partner data and administration | ||
|
|
||
| For an explanation of the **Partner data** and **Your integrations** sections shown at the top of the report, see [Partner data and integrations](./app-connector-auditor-partnergegevens). |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link reference points to "app-connector-auditor-partnergegevens" which is the Dutch filename. In the English version, this should point to "app-connector-auditor-partnerinfo" (the English equivalent file).
| For an explanation of the **Partner data** and **Your integrations** sections shown at the top of the report, see [Partner data and integrations](./app-connector-auditor-partnergegevens). | |
| For an explanation of the **Partner data** and **Your integrations** sections shown at the top of the report, see [Partner data and integrations](./app-connector-auditor-partnerinfo). |
|
|
||
| This help is intended as a **reference work and technical specification**, not as a replacement for personal consultation. | ||
|
|
||
| This document is never finished. Do you see something that is incorrect, or do you have suggestions for improvement? Make a pull request on the [GitHub page of the documentation](https://github.com/AFASSoftware/OASContent/blob/main/markdownpages/profit/en/app-connector-auditor-developer.md). |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GitHub link points to "app-connector-auditor-partner.md" (Dutch version) but this is the English version of the developer documentation. The link should point to "app-connector-auditor-developer.md" in the English folder to match the current file.
| - [ ] **Je certificering is afgerond** | ||
| - [ ] **Je integratie wordt getoond op [https://partner.afas.nl/koppelingen](https://partner.afas.nl/koppelingen)** | ||
| **Niveau:** ❌ Fout | ||
| **Certificerings-impact:** **Blokkeert certificering\*\* |
Copilot
AI
Jan 25, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent formatting: "**Blokkeert certificering**" has incorrect closing markup. It should be "Blokkeert certificering" with double asterisks on both sides.
| **Certificerings-impact:** **Blokkeert certificering\*\* | |
| **Certificerings-impact:** **Blokkeert certificering** |
No description provided.