Client #50: Design system — color palette, typography, and theme#54
Open
FadyGergesRezk wants to merge 2 commits into
Open
Client #50: Design system — color palette, typography, and theme#54FadyGergesRezk wants to merge 2 commits into
FadyGergesRezk wants to merge 2 commits into
Conversation
FadyGergesRezk
requested review from
f-s-h and
raphael-frank
and removed request for
raphael-frank
Collaborator
|
Borders and shadows of cards cannot be seen in dark mode |
Collaborator
|
Rest lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The web client had no visual foundation — no defined colour palette, no typography scale. This establishes the full design system that all feature pages will build on, closing the blocker for issue #43.
What changed
lumio/lumio-darktheme pair using daisyUI v5 CSS custom properties with full semantic color tokensdisplay-xsthroughdisplay-2xlfor Bebas Neue headings, andh1–h4/body/caption/monofor Poppins proseThemeProvider,ThemeContext,useThemehook, andThemeTogglebutton with Lucide icons (Sun/Moon) — theme persists tolocalStorageand falls back to OS preferencefont-displayto the app title and page titles inAppRouter.tsxCLAUDE.mdwith branch naming, conventional commit, and PR conventions for the repopayments/client.tsbase URL (/finances→/finance) and added Vite dev proxy for/apiNotes
Poppins ships Devanagari subsets by default via
@fontsource. If the app is Latin-only, swap imports to@fontsource/poppins/latin-400.cssetc. to trim ~160 KB from the font bundle.Testing
pnpm buildpasses with no type errors. All pre-commit hooks (lint, typecheck, tests, build) pass. Dark mode toggle switches theme and persists across page reloads.Closes #50