Conversation
|
mediator timestamps are a bit strange, hence the minor difference in mediator vs mom runoff plots: 
|
|
Thanks @anton-seaice - do you think this is ready for the next 25km IAF test run? |
|
Ready from my perspective.
|
There was a problem hiding this comment.
There isn't much flexibility in the mediator io. I modified this so that it can read 3d variable (x,y,time) from a netcdf . For whatever reason, 3d information in restart files is saved in separate 2d variables so the functionality didn't exisit.
|
I did some cleanup, but have finished that for now |
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
Nice work @anton-seaice. Sorry for taking so long to get to this.
My main worry is the lack of time interpolation and the resulting step changes in the pattern between months. But, as we've discussed, we probably can't address that here.
| !------------------------------------------------------------------------------- | ||
| #endif | ||
|
|
||
| rc = ESMF_SUCCESS |
There was a problem hiding this comment.
Why is this needed? Is this just convention (e.g. in case someone adds an early return path or something)?
There was a problem hiding this comment.
It seemed like convention, maybe it's not actually needed
| rcode = pio_inq_dimlen(pioid, dimid(1), lnx) | ||
| if (rcode /= pio_noerr) then | ||
| ierr = pio_strerror(rcode, tmpstr) | ||
| call shr_sys_abort(trim(subname)//' ERROR: '//trim(tmpstr), rc=rc) |
There was a problem hiding this comment.
How come you call shr_sys_abort here, but shr_log_error for lny and lni below?
| call ESMF_LogWrite(trim(subname)//trim(tmpstr), ESMF_LOGMSG_INFO, rc=rc) | ||
| fldptr2 = 0.0_r8 |
There was a problem hiding this comment.
Not 100% sure, I just followed existing behaviour I think
There might be use cases where its ok to restart with missing fields ?
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
| !------------------------------------------------------------------------------- | ||
| #endif | ||
|
|
||
| rc = ESMF_SUCCESS |
There was a problem hiding this comment.
It seemed like convention, maybe it's not actually needed
| call ESMF_LogWrite(trim(subname)//trim(tmpstr), ESMF_LOGMSG_INFO, rc=rc) | ||
| fldptr2 = 0.0_r8 |
There was a problem hiding this comment.
Not 100% sure, I just followed existing behaviour I think
There might be use cases where its ok to restart with missing fields ?
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
3 participants
This change allows for spreading of the iceberg melt field according to a climatological pattern.
A new configuration parameter is added,
rof2ocn_ice_spread- which is the filename for a netcdf file with a 12-monthly climatological spreading pattern. If this parameter is not set - there is no change to existing behaviour (see repro test)When a file is provided, the incoming
Forr_rofifield is spread according to the pattern supplied in the climatology of spreading.e.g., for January:
and for June:
Water volume is maintained between that coming from drof and ficeberg in MOM:
See example OM3 100km configuration:
ACCESS-NRI/access-om3-configs@3169a38