Assignment two #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Updated Assignment2.md, assignment2.sql. Kindly let me know the updates required. Thank you. |
DwardEE
approved these changes
Aug 25, 2025
DwardEE
left a comment
DwardEE
left a comment
There was a problem hiding this comment.
Strong work!
Two tune-ups: (1) In the cross-join revenue query you’re not using the customer count, multiply by it so the metric is 5 * cc.num_customers * vp.original_price (and you can drop SUM if vendor_products is one row per vendor/product). (2) For the Apple Pie INSERT, SELECT * can copy non-unit rows and colide on product_id; explicitly list columns, ensure product_qty_type='unit', or geneate a new id. Overall, clean and correct! No major changes are necessary so I'll mark the assignment as complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist