Prevent intel-gtk-fix.conf generation without Intel iGPU by 8r4n · Pull Request #4 · 8r4n/bazzite

8r4n · 2026-03-21T00:45:35Z

No description provided.

Copilot

Pull request overview

Updates dynamic Intel GTK fix detection to avoid creating intel-gtk-fix.conf when the Intel graphics driver isn’t actively used, and includes several installer/runtime packaging tweaks.

Changes:

Refine Intel GPU module detection logic in bazzite-dynamic-fixes.
Adjust Steam launcher behavior and remove extest preload/install.
Modify installer behavior (KDE pins) and introduce an overlay mount for Flatpak state in the live environment.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
system_files/desktop/shared/usr/libexec/bazzite-dynamic-fixes	Changes Intel driver detection gating for `intel-gtk-fix.conf` creation/removal
system_files/desktop/shared/usr/bin/bazzite-steam	Removes ally handling and drops Wayland `extest` preload path
installer/build.sh	Replaces Flatpak “copy” protection with an overlayfs-backed mount unit
installer/titanoboa_hook_postrootfs.sh	Adds KDE default pin/layout manipulation via `sed`
Containerfile	Removes downloading/installing `extest` shared library
system_files/desktop/shared/usr/share/ublue-os/bazaar/content.yaml	Adds UZDoom Flatpak entry
.github/workflows/scorecard.yml	Updates pinned digest for upload-sarif action
.github/workflows/generate_release.yml	Updates pinned digest for action-gh-release
system_files/desktop/silverblue/usr/share/gnome-shell/extensions/tmp/caffeine	Bumps subproject commit pointer
system_files/desktop/silverblue/usr/share/gnome-shell/extensions/appindicatorsupport@rgcjonas.gmail.com	Bumps subproject commit pointer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-22T15:47:38Z

+# Mount an overlayfs in in order to avoid flatpak files being altered by users on the live session
+mv -T /var/lib/flatpak{,_original}
+mkdir -p /var/lib/flatpak{,.work}
+cat <<EOF >/etc/systemd/system/var-lib-flatpak.mount
+[Mount]
+Type=overlay
+What=overlay
+Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work
+
+[Install]
+WantedBy=multi-user.target
+EOF
+systemctl enable var-lib-flatpak.mount


The generated systemd .mount unit is missing Where=/var/lib/flatpak, which is required for mount units. Also, upperdir=/var/lib/flatpak is the same path as the mountpoint (/var/lib/flatpak), which is not a valid overlayfs configuration and is likely to fail to mount. Use distinct backing directories (e.g., /var/lib/flatpak_upper and /var/lib/flatpak_work) and set Where=/var/lib/flatpak in the unit.

Copilot · 2026-03-22T15:47:38Z


-# Make a copy of the original flatpak files in order to avoid being altered by users on the live session
-cp -aT /var/lib/flatpak{,_original}
+# Mount an overlayfs in in order to avoid flatpak files being altered by users on the live session


Correct the duplicated word 'in' in the comment.

Suggested change

# Mount an overlayfs in in order to avoid flatpak files being altered by users on the live session

# Mount an overlayfs in order to avoid flatpak files being altered by users on the live session

Copilot · 2026-03-22T15:47:38Z

+if lsmod | awk '$3 > 0' | grep -P "^(xe|i915) " > /dev/null && [ ! -f "$HOME/.config/environment.d/intel-gtk-fix.conf" ]; then
    # User is using an Intel GPU
    write_intel_gtk_fix
-elif ! lsmod | grep -P "^(xe|i915) " > /dev/null && [ -f "$HOME/.config/environment.d/intel-gtk-fix.conf" ]; then
+elif ! lsmod | awk '$3 > 0' | grep -P "^(xe|i915) " > /dev/null && [ -f "$HOME/.config/environment.d/intel-gtk-fix.conf" ]; then


Filtering lsmod by $3 > 0 uses the module refcount/dependency count as a proxy for “GPU present/active”, but Used by may be 0 even when a driver is bound to hardware (no dependent modules). This can prevent intel-gtk-fix.conf from being created on Intel systems. A more reliable approach is to detect Intel DRM devices via /sys/class/drm/card*/device/vendor (0x8086) and/or the bound driver name, rather than relying on lsmod refcounts.

Copilot · 2026-03-22T15:47:39Z

+    sed -i '/const allPanels/,$d' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js
+    sed -i '$r /usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/bazzite-pins.js' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js


These sed -i operations can fail (missing file, upstream layout changes, missing const allPanels marker). In an installer context this can abort the install if the script runs with set -e (or equivalent). Consider guarding with file/marker checks and/or appending || : (similar to the GNOME sed usage later in this script) so the installer remains resilient across Plasma version/layout changes.

Suggested change

sed -i '/const allPanels/,$d' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

sed -i '$r /usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/bazzite-pins.js' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

layout_js="/usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js"

pins_js="/usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/bazzite-pins.js"

if [[ -f "$layout_js" && -f "$pins_js" ]] && grep -q 'const allPanels' "$layout_js"; then

sed -i '/const allPanels/,$d' "$layout_js" || :

sed -i '$r '"$pins_js" "$layout_js" || :

fi

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-24T15:05:17Z

+mkdir -p /var/lib/flatpak{,.work}
+cat <<EOF >/etc/systemd/system/var-lib-flatpak.mount
+[Mount]
+Type=overlay
+What=overlay
+Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work


This overlay mount configuration is invalid/fragile because upperdir points to the same path as the mountpoint (/var/lib/flatpak). Overlayfs requires upperdir (and workdir) to be separate directories that are not the mountpoint itself; otherwise the mount can fail (EINVAL) or behave unexpectedly. Use distinct directories (e.g., /var/lib/flatpak.upper and /var/lib/flatpak.work) and mount them onto /var/lib/flatpak.

Suggested change

mkdir -p /var/lib/flatpak{,.work}

cat <<EOF >/etc/systemd/system/var-lib-flatpak.mount

[Mount]

Type=overlay

What=overlay

Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work

mkdir -p /var/lib/flatpak{,.upper,.work}

cat <<EOF >/etc/systemd/system/var-lib-flatpak.mount

[Mount]

Type=overlay

What=overlay

Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak.upper,workdir=/var/lib/flatpak.work

Copilot · 2026-03-24T15:05:18Z

+[Mount]
+Type=overlay
+What=overlay
+Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work


The generated .mount unit is missing Where=/var/lib/flatpak. Even though the unit name implies the mountpoint, systemd mount units typically require an explicit Where= to be set in the [Mount] section; omitting it can cause the unit to be rejected or not behave as intended across systemd versions.

Suggested change

Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work

Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work

Where=/var/lib/flatpak

Copilot · 2026-03-24T15:05:18Z

 }

-if lsmod | grep -P "^(xe|i915) " > /dev/null && [ ! -f "$HOME/.config/environment.d/intel-gtk-fix.conf" ]; then
+if lsmod | awk '$3 > 0' | grep -P "^(xe|i915) " > /dev/null && [ ! -f "$HOME/.config/environment.d/intel-gtk-fix.conf" ]; then


The PR title focuses on preventing intel-gtk-fix.conf generation without an Intel iGPU, but this PR also includes unrelated changes (Steam launcher behavior, removal of extest from the image, Flatpak overlay mount in installer, KDE pin edits, workflow pin updates, app list changes, and Gamescope version bump). Consider splitting into separate PRs or updating the title/description to reflect the broader scope.

…4735) This prevents `systemctl disable` commands from failing if a unit file does not exist, which specifically addresses the root cause of the ISO build failure.

…ion (#4737) This time for the titanoboa workflow

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…hell/extensions/tmp/bazaar-integration@kolunmi.github.io digest to 3bb9134 (#4740) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(liveiso): remove "enable root account" and legacy branding * add overrides folder * move other overrides to its folder * copy overrides *after* postfs * don't forcefully copy files on first system copy it doesn't contain overrides anymore

* feat: add steam first run window * remove bazzite-steam duplicate for nvidia * move steamclient.dll check to firstrun script * wording * Revert "remove bazzite-steam duplicate for nvidia" This reverts commit 4c9b2d3. * add firstrun to nvidia * add a flag to disable firstrun and add to fix-reset-steam * do that for nvidia too

* feat: add ger/spa/fr/it translation to steam-first-run * Update system_files/desktop/shared/usr/bin/bazzite-steam-firstrun Co-authored-by: renner <80410025+renner0e@users.noreply.github.com> --------- Co-authored-by: renner <80410025+renner0e@users.noreply.github.com>

… builds for now

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* split flatpak blocklist for kionite and silverblue * split flatpak blocklist for kionite and silverblue * Delete system_files/desktop/shared/usr/share/ublue-os/flatpak-blocklist

This adds a systemd quadlet for the Cockpit web service along with a "shim" service to allow enablement via ujust. If we put an install section, the Cockpit quadlet would be enabled by default.

* docs: update Russian README translation * docs(readme): address markdown lint notices * docs(readme): use Markdown syntax for count badge

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

…hell/extensions/blur-my-shell@aunetx digest to 6f78738 (#5028) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

…hell/extensions/blur-my-shell@aunetx digest to 6f78738 (#5028) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

…hell/extensions/blur-my-shell@aunetx digest to 382c798 (#5034) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

…-beta install (#5036) * fix: write sunshine.conf capture and system_tray settings before starting beta service * fix: write sunshine.conf capture and system_tray settings before starting beta service

…5044) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

* feat(sunshine): add notice for deck Add and updated notices for deck and desktop users. Also adds a conditional to make #5036 (auto-set capture=kms and sys_tray=disabled) activate on deck only. * feat(sunshine): Prettify messages Add yellow coloring to any "Sunshine" that refers to the installed package of Sunshine. Add bold to links and keyword * feat(sunshine): add option to keep data on delete

…resolved

This reverts commit 3f1f219.

Copilot AI review requested due to automatic review settings March 22, 2026 15:45

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 24, 2026 15:02

Copilot AI reviewed Mar 24, 2026

View reviewed changes

dylanmtaylor and others added 26 commits April 27, 2026 16:34

chore: add conditional disabling for systemd units in titanoboa hook (#…

eedf70d

…4735) This prevents `systemctl disable` commands from failing if a unit file does not exist, which specifically addresses the root cause of the ISO build failure.

ci: Enable building ISOs from unstable branch (#4736)

1383823

ci: Enable building ISOs from unstable branch for new image verificat…

f010717

…ion (#4737) This time for the titanoboa workflow

chore: Ensure old file is removed

98ee355

feat: Use Fedora packages for obs-studio-plugin-vkcapture

bf838d2

chore: Minor typo fix

a2d87e7

chore: Remove now unneeded repository

218a125

chore(deps): update sigstore/cosign-installer action to v4.1.1 (#4741)

fc305f8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update system_files/desktop/silverblue/usr/share/gnome-s…

81cafdf

…hell/extensions/tmp/bazaar-integration@kolunmi.github.io digest to 3bb9134 (#4740) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore: drop mutter's disable tegra patch (#4743)

5775a36

chore: Clean up random bluez media patch file from mutter (#4744)

fec54aa

chore: drop gnome-shell spec files since we're not patching it (#4742)

966f359

feat(porta): add portal to prepinned apps (#4608)

5ecd314

fix(liveiso): exclude conky from gnome and adjust services (#4746)

61e3be4

feat: add Greek translation for Steam first run message (#4747)

abd9b6c

fix: rephrased the french translation (#4749)

1db58ef

feat: add Brazilian Portuguese translation to steam-first-run (#4750)

388b726

Merge branch 'testing' into unstable

3413419

feat(ci): Drop legacy ISO builder, rename live ISO builder, drop deck…

feeb69f

… builds for now

Merge branch 'unstable'

4a49fe9

chore(deps): update sigstore/cosign-installer action to v4.1.1 (#4752)

5b9a347

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: allow Ptyxis to be downloaded as flatpak on KDE (#4753)

0cca452

* split flatpak blocklist for kionite and silverblue * split flatpak blocklist for kionite and silverblue * Delete system_files/desktop/shared/usr/share/ublue-os/flatpak-blocklist

feat: add cockpit quadlet (#4755)

44eda26

This adds a systemd quadlet for the Cockpit web service along with a "shim" service to allow enablement via ujust. If we put an install section, the Cockpit quadlet would be enabled by default.

nyx1d and others added 30 commits June 3, 2026 22:16

docs(readme): sync Russian translation with English version (#5018)

b45d9fb

* docs: update Russian README translation * docs(readme): address markdown lint notices * docs(readme): use Markdown syntax for count badge

chore(deck): Clean up return-to-gamemode in KDE

4f8015b

Merge branch 'unstable' into testing

fb0d670

chore(deps): update actions/checkout digest to df4cb1c (#5025)

9866419

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update github/codeql-action digest to 87557b9 (#5026)

a89b4c0

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update github/codeql-action digest to 8aad20d (#5031)

caea22d

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update actions/checkout action to v6.0.3 (#5030)

acf805e

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update system_files/desktop/silverblue/usr/share/gnome-s…

9089489

…hell/extensions/blur-my-shell@aunetx digest to 6f78738 (#5028) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update actions/checkout digest to df4cb1c (#5025)

e96fcde

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update github/codeql-action digest to 87557b9 (#5026)

f34d823

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update github/codeql-action digest to 8aad20d (#5031)

d187e2c

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update actions/checkout action to v6.0.3 (#5030)

bc02e24

Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(deps): update system_files/desktop/silverblue/usr/share/gnome-s…

3ef7e9d

…hell/extensions/blur-my-shell@aunetx digest to 6f78738 (#5028) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

fix(deck): Further session adjustments to match current SteamOS

308880c

chore: Fix missing package

641b439

chore: Remove entirely for now, more issues

c55b3c0

chore: Fix missing package

42799a4

chore: Remove entirely for now, more issues

762aa67

chore: Use _ for ryzen_smu

6d8ef43

chore: Use _ for ryzen_smu

eecbe8b

chore(deps): update system_files/desktop/silverblue/usr/share/gnome-s…

67b646b

…hell/extensions/blur-my-shell@aunetx digest to 382c798 (#5034) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

fix(deck): fix: set capture=kms and system_tray=disabled for sunshine…

45eed93

…-beta install (#5036) * fix: write sunshine.conf capture and system_tray settings before starting beta service * fix: write sunshine.conf capture and system_tray settings before starting beta service

chore(deps): update dataaxiom/ghcr-cleanup-action action to v1.2.2 (#…

4b64d21

…5044) Co-authored-by: ubot-7274[bot] <217212047+ubot-7274[bot]@users.noreply.github.com>

chore(nvidia): Add patched kwin spec

dfc32fa

fix(nvidia): Use patched kwin until issue w/ latest Nvidia driver is …

6423dfb

…resolved

Merge branch 'testing'

450bd3e

Reapply "Reapply "revertme: Disable -deck builds on :testing for now""

c8e3f5e

This reverts commit 3f1f219.

chore(gnome): Disable popup blur by default

73c1fca

Merge branch 'testing'

e026acf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent intel-gtk-fix.conf generation without Intel iGPU#4

Prevent intel-gtk-fix.conf generation without Intel iGPU#4
8r4n wants to merge 615 commits into
8r4n:mainfrom
ublue-os:main

8r4n commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Copilot AI Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

	# Mount an overlayfs in in order to avoid flatpak files being altered by users on the live session
	# Mount an overlayfs in order to avoid flatpak files being altered by users on the live session

		sed -i '/const allPanels/,$d' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js
		sed -i '$r /usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/bazzite-pins.js' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

-    sed -i '/const allPanels/,$d' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js
-    sed -i '$r /usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/bazzite-pins.js' /usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js
+    layout_js="/usr/share/plasma/layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js"
+    pins_js="/usr/share/plasma/shells/org.kde.plasma.desktop/contents/updates/bazzite-pins.js"
+    if [[ -f "$layout_js" && -f "$pins_js" ]] && grep -q 'const allPanels' "$layout_js"; then
+        sed -i '/const allPanels/,$d' "$layout_js" || :
+        sed -i '$r '"$pins_js" "$layout_js" || :
+    fi

	Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work
	Options=lowerdir=/var/lib/flatpak_original,upperdir=/var/lib/flatpak,workdir=/var/lib/flatpak.work
	Where=/var/lib/flatpak

Conversation

8r4n commented Mar 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants