updated Date Form Input to support nova-v3 format picker#213
Open
prima-ca wants to merge 2 commits into64robots:masterfrom
Open
updated Date Form Input to support nova-v3 format picker#213prima-ca wants to merge 2 commits into64robots:masterfrom
prima-ca wants to merge 2 commits into64robots:masterfrom
Conversation
Contributor
|
Hi @prima-ca thanks for your contribution. Our team has been reviewing you PR and a little detail has caught our attention. What's the benefit of adding the new class to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the Date form-field components up to the current Nova v3.29 capabilities, most importantly allowing the specification of alternate date formats, as described in https://nova.laravel.com/docs/3.0/resources/fields.html#date-formats
e.g.
The same could/should be done for DateTime, but as I haven't personally needed it... shrug
The package.json and yarn.lock file are also slightly modified to allow usage of node-sass@^6.0.1 as the old node-sass just doesn't compile.