Add support for operator in labels #317
Open
+96
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to match labels with regular expressions.
piptouque
force-pushed
the
feat_add_label_ops
branch
from
de36598 to
3d17b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull requests adds support for operators other than exact equality when fetching metrics.
Proposal
We add an optional operator to the
label_configdata that's passed toPrometheusConnect.get_current_metric_valueandPrometheusConnect.get_metric_range_data. The default is=and previous behaviour is unchanged.PrometheusConnect.get_current_metric_valueandPrometheusConnect.get_metric_range_dataquery_to_strmethod