Skip to content

Disable node processing completely to avoid issues with tool scripts #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ryevdokimov wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Disable node processing completely to avoid issues with tool scripts #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/scene_library.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,7 @@ func _create_thumb(item: Dictionary[StringName, Variant], callback: Callable) ->
return callback.call()

var instance: Node = packed_scene.instantiate()
_disable_node_processing(instance)

_viewport.call_deferred(&"add_child", instance)
await instance.ready
Expand Down Expand Up @@ -1068,6 +1069,12 @@ func _create_thumb(item: Dictionary[StringName, Variant], callback: Callable) ->

callback.call()

func _disable_node_processing(node: Node) -> void:
node.set_process_mode(Node.PROCESS_MODE_DISABLED)

for child in node.get_children():
_disable_node_processing(child)
Comment on lines +1073 to +1076
Copy link
Copy Markdown
Owner

@4d49 4d49 Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the forced assignment of PROCESS_MODE_INHERIT is better, since if it is already assigned, then nothing will happen(c++ code under the hood of the engine).

Also, the get_children method is quite expensive (at least my old tests showed it).

Suggested change
node.set_process_mode(Node.PROCESS_MODE_DISABLED)
for child in node.get_children():
_disable_node_processing(child)
node.set_process_mode(Node.PROCESS_MODE_INHERIT)
for i: int in node.get_child_count(true):
_disable_node_processing(node.get_child(i))


func _thread_process() -> void:
var semaphore := Semaphore.new()

Expand Down