fix: keep unsigned dev builds from corrupting shared keychain state#1
Merged
Conversation
The file-based dev vault (used by unsigned builds) shares config.json with signed builds. It could advance the auth-storage version, migrate, or delete the legacy auth store -- making a later signed release skip its real Keychain migration and find no saved auth. Keychain migration, repair, and legacy cleanup now run only when the Keychain backend is active. The menu app also now pins the codex-profile helper it launches to its own auth backend (CODEX_PROFILE_FILE_AUTH_STORE_DIR / CODEX_PROFILE_FORCE_KEYCHAIN), so an app and its delegated helper can no longer split a login across two stores when their signing identities differ. Adds regression coverage: a unit test proving the file vault leaves the shared version and legacy store untouched, and an integration test proving the backend override pins the helper's store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial-review follow-up. Two HIGH findings, both confirmed genuine and fixed:
config.jsonwith signed builds and could advance the auth-storage version, migrate, or delete the legacy auth store, making a later signed release skip its real Keychain migration and find no saved auth. Keychain migration/repair/cleanup now run only when the Keychain backend is active.codex-profilehelper it launches to its own auth backend, so a signing-identity mismatch can no longer split a login across two stores.Regression coverage added (unit + integration). Build green, all tests pass. Dev/mixed-install hardening only — signed-release users were never exposed.