Download completion schema from 4C#135
Merged
rjoussen merged 2 commits intoMay 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Extends the existing nightly metadata/schema update workflow to also download the new 4C_schema_completion.json artifact from 4C, hash-compare it alongside the metadata and schema files, and commit any changes together. A placeholder 4C_schema_completion.json is added so the first nightly run has a baseline file to overwrite.
Changes:
- Add a placeholder
src/fourcipp/config/4C_schema_completion.jsonto be replaced by the first nightly update. - Download the
clang18_build-completion-schemaartifact from 4C in the nightly workflow and include it in the pre-commit formatting step. - Generalize the change-detection logic to compute hashes for metadata, schema, and completion schema files, and rename the job/env var (
metadata_file_changed→generated_files_changed) accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fourcipp/config/4C_schema_completion.json | Placeholder JSON seeded so the nightly workflow can overwrite it. |
| .github/workflows/update_4C_metadata_schema_file.yaml | Adds completion-schema download, hashing, conditional move, and renames job/env var to reflect multiple generated files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davidrudlstorfer
approved these changes
May 30, 2026
davidrudlstorfer
left a comment
davidrudlstorfer
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the changes and also thanks for improving the logic :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This downloads the completion schema nightly such that the fourcipp tests can run on it (after the first nightly update succeeded). Currently, I add an empty completion schema which should trigger an update tonight (following 4C-multiphysics/4C#2006). Afterwards, the tests in #134 should pass and can be merged.