Skip to content

Update the lnm cluster presets to actual current capabilities at the cluster bruteforce#2087

Merged
c-p-schmidt merged 1 commit into
4C-multiphysics:mainfrom
c-p-schmidt:update-lnm-bruteforce-presets-to-actual-capabilities
Jun 18, 2026
Merged

Update the lnm cluster presets to actual current capabilities at the cluster bruteforce#2087
c-p-schmidt merged 1 commit into
4C-multiphysics:mainfrom
c-p-schmidt:update-lnm-bruteforce-presets-to-actual-capabilities

Conversation

@c-p-schmidt

@c-p-schmidt c-p-schmidt commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Description and Context

As the title states.

@c-p-schmidt c-p-schmidt self-assigned this Jun 17, 2026
Copilot AI review requested due to automatic review settings June 17, 2026 14:25
@c-p-schmidt

c-p-schmidt commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This is the pipeline in the lnm config repo: https://gitlab.lrz.de/baci/baci-config-lnm/-/pipelines/3124976
Edited, after I finally realized that I need to choose my fork, it is actually running. 😅

Copilot AI reviewed Jun 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the LNM “bruteforce” CMake preset to better match the cluster environment by adjusting which optional components are enabled during configuration.

Changes:

  • Disables Python for the lnm_bruteforce preset and removes the preset’s Python root path.
  • Attempts to disable Trilinos MUMPS/SuperLUDist via preset cache variables.

Comment thread presets/lnm/cluster/CMakePresets.json Outdated
@c-p-schmidt

c-p-schmidt commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

This is the pipeline in the lnm config repo: https://gitlab.lrz.de/baci/baci-config-lnm/-/pipelines/3124976 Edited, after I finally realized that I need to choose my fork, it is actually running. 😅

The original approach worked. Now I’m checking whether Copilot is correct. This pipeline runs here: https://gitlab.lrz.de/baci/baci-config-lnm/-/pipelines/3125476

davidrudlstorfer
davidrudlstorfer approved these changes Jun 18, 2026
View reviewed changes

@davidrudlstorfer davidrudlstorfer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also trying out the new suggestion :)

@c-p-schmidt
Update the lnm cluster presets to
3893f7f 
actual current capabilities at the cluster bruteforce.
@c-p-schmidt c-p-schmidt force-pushed the update-lnm-bruteforce-presets-to-actual-capabilities branch from 233c002 to 3893f7f Compare June 18, 2026 06:38
@c-p-schmidt c-p-schmidt enabled auto-merge June 18, 2026 06:38
@c-p-schmidt

c-p-schmidt commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Also, the second pipeline passed. So I squashed the commits, and we go with the Copilot suggestion.

@c-p-schmidt c-p-schmidt merged commit 8aeb019 into 4C-multiphysics:main Jun 18, 2026
44 checks passed
@c-p-schmidt c-p-schmidt deleted the update-lnm-bruteforce-presets-to-actual-capabilities branch June 18, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lauraengelhardt lauraengelhardt lauraengelhardt approved these changes

@davidrudlstorfer davidrudlstorfer davidrudlstorfer approved these changes

Assignees

@c-p-schmidt c-p-schmidt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@c-p-schmidt @lauraengelhardt @davidrudlstorfer