Clean up embeddedmesh implementation#1614
Open
eulovi wants to merge 1 commit into
Open
Conversation
2 tasks
maxfirmbach
reviewed
Dec 23, 2025
maxfirmbach
left a comment
Contributor
There was a problem hiding this comment.
Overall looks nice 👍. I have left some comments 😃.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the embedded-mesh constraint implementation in constraint_framework to make it extensible beyond the Mortar method by introducing a common SolidToSolidCouplingManager base and routing evaluation/output through a selected coupling strategy.
Changes:
- Introduces
SolidToSolidCouplingManagerbase class and moves shared embedded-mesh setup/cut/output-integration-point logic into it. - Updates
EmbeddedMeshConstraintManagerto construct and use a strategy-specific coupling manager (currently Mortar). - Adapts
SolidToSolidMortarManagerto inherit from the new base and override the strategy-specific assembly/output/energy pieces.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/constraint_framework/4C_constraint_framework_submodelevaluator_embeddedmesh.hpp | Switches embedded-mesh submodel evaluator to a coupling-strategy-based manager interface. |
| src/constraint_framework/4C_constraint_framework_submodelevaluator_embeddedmesh.cpp | Implements parameter extraction and coupling-manager factory logic; routes evaluation/output/energy through the manager. |
| src/constraint_framework/4C_constraint_framework_embeddedmesh_solid_to_solid_mortar_manager.hpp | Makes Mortar manager derive from SolidToSolidCouplingManager and overrides the base interface. |
| src/constraint_framework/4C_constraint_framework_embeddedmesh_solid_to_solid_mortar_manager.cpp | Adjusts Mortar manager construction/setup and renames the force/stiffness contribution API to match the base. |
| src/constraint_framework/4C_constraint_framework_embeddedmesh_solid_to_solid_coupling_manager.hpp | Adds the new common base class API/state shared by embedded-mesh coupling managers. |
| src/constraint_framework/4C_constraint_framework_embeddedmesh_solid_to_solid_coupling_manager.cpp | Implements shared cut/setup, visualization registration, and helper utilities for coupling managers. |
4243c5e to
a6b83d0
Compare
a6b83d0 to
80ebb25
Compare
eulovi
commented
Jun 10, 2026
eulovi
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for your comments @maxfirmbach @isteinbrecher (and sorry for taking so long to resolve this)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
One problem that I noticed in the PR #1613 is that the current
embeddedmeshimplementation inconstraint_frameworkis not flexible enough to add new coupling strategies. So far, only the Mortar method is implemented. Therefore, in this PR a base classSolidToSolidCouplingManageris introduced. This class can work as a base class for other methods and holds basic functionality needed for embedded mesh strategies. Also I tried to clean how parameters are obtained, so that no unnecessary parameters are called if the coupling strategy doesn't require them.Related Issues and Pull Requests
Related to #1613