⚡ Optimize MicrotubuleTorus with InstancedMesh#66
Conversation
- Refactored MicrotubuleTorus to use InstancedMesh, reducing draw calls from ~1082 to ~4.
- Implemented efficient matrix updates using a reusable THREE.Object3D in useFrame.
- Ensured proper React Three Fiber lifecycle management with key={count}.
- Verified optimization markers and code formatting.
Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced individual
<mesh>components with a singleTHREE.InstancedMeshin theMicrotubuleToruscomponent.🎯 Why: Rendering 1080 individual meshes (360 + 720) was causing over 1000 draw calls, which is extremely inefficient.
InstancedMeshallows rendering all instances in a single draw call, significantly reducing CPU-GPU overhead.📊 Measured Improvement:
InstancedMeshcomponent + 2 for lighting).PR created automatically by Jules for task 15816259136041021962 started by @jason420247