EDSL ideas#1
Open
michaeldeluna wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
make-it-easy is probably has a definitive answer in it - suspect all things are builders and they get built just before the outer-most build() instance is required |
michaeldeluna
commented
Jan 27, 2018
| @Test void hitTheSample() throws IOException, KeyManagementException, NoSuchAlgorithmException { | ||
| ResourceLeakDetector.setLevel(ResourceLeakDetector.Level.PARANOID); | ||
|
|
||
| server = App.mu_server_builder.start(); |
Contributor
Author
There was a problem hiding this comment.
Discovered a port clash here when I left the main() one running - which led me to the builder rabbit hole
michaeldeluna
commented
Jan 27, 2018
| public class App { | ||
| public static final Logger log = LoggerFactory.getLogger(App.class); | ||
|
|
||
| public static final MuServerBuilder mu_server_builder = MuServerBuilder.muServer() |
Contributor
Author
There was a problem hiding this comment.
Moved out as a field so that the prototypical server was accessible from test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whacked the import list by mistake ... feel free to ignore that bit