feat(DataGrid): Add button in the side panel to reset all filters#90
Draft
avorobiov-unicrew wants to merge 10 commits intomainfrom
Draft
feat(DataGrid): Add button in the side panel to reset all filters#90avorobiov-unicrew wants to merge 10 commits intomainfrom
avorobiov-unicrew wants to merge 10 commits intomainfrom
Conversation
avorobiov-unicrew
force-pushed
the
fix/DEV-8460-sidebar-reset-all-filters
branch
from
866cbfb to
0ffb83c
Compare
| .some(([key, value]) => JSON.stringify(this.initialParameters[key]) !== JSON.stringify(value)) | ||
| } | ||
|
|
||
| private restoreDefaultParameters = () => { |
Contributor
Author
There was a problem hiding this comment.
restoreDefaultParameters should be separate to ensure compatibility with future ModdableDataGrid.
| .filter(([_, value]) => value !== undefined | ||
| && value !== '' | ||
| && (!(value instanceof Array) || value.length > 0)) | ||
| .some(([key, value]) => JSON.stringify(this.initialParameters[key]) !== JSON.stringify(value)) |
Contributor
Author
There was a problem hiding this comment.
We have similar stuff in ModdableDataGrid (see definedParameters) but I am unsure if we need to install @a11d/equals here. Maybe we should somehow make this package global? (like structuredClone polyfill)
added 10 commits
November 18, 2024 11:36
…ton in the side panel
a11delavar
force-pushed
the
fix/DEV-8460-sidebar-reset-all-filters
branch
from
41fabb0 to
ed54b75
Compare
a11delavar
force-pushed
the
main
branch
2 times, most recently
from
60da515 to
46819b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be reviewed by Lilia first.