Open
Conversation
Contributor
pdrillin
commented
Jan 20, 2021
- Ticket : fixes Ajouter les actions de contrôle de qualité du code #9
Contributor
|
I'm wondering what would we the best strategy for such analysis. These errors are here because it's missing the parent project Lizmap.
@drillinP Can you launch phpstan locally, where you have Lizmap installed, these errors should go away, right ? (and maybe real errors will occur) |
Gustry
reviewed
Jan 21, 2021
Contributor
|
@drillinP Gentle ping for the discussion above, can you add what you tried what as working/not working ? Thanks |
Contributor
Author
|
@Gustry I have launch phpstan locally with lizmap and i have same errors |
Contributor
Author
|
@Gustry I think that it is necessary to define the variables coming from other projects upstream in a config file to be able to use phpstan correctly, but this file can become very long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.