Skip to content

Adding PhpStan#10

Open
pdrillin wants to merge 1 commit into3liz:mainfrom
pdrillin:main
Open

Adding PhpStan#10
pdrillin wants to merge 1 commit into3liz:mainfrom
pdrillin:main

Conversation

@pdrillin
Copy link
Contributor

@Gustry
Copy link
Contributor

Gustry commented Jan 21, 2021

I'm wondering what would we the best strategy for such analysis. These errors are here because it's missing the parent project Lizmap.

  • Add on the exclude list these "upstream objects", but I think we are going to miss the main reason of this analysis, checking members, properties etc ...
  • Adding Lizmap as required in the composer.json?
  • Launching in a lizmap docker image ?
  • Other options?

@drillinP Can you launch phpstan locally, where you have Lizmap installed, these errors should go away, right ? (and maybe real errors will occur)

@Gustry
Copy link
Contributor

Gustry commented Jan 29, 2021

@drillinP Gentle ping for the discussion above, can you add what you tried what as working/not working ? Thanks

@pdrillin
Copy link
Contributor Author

pdrillin commented Feb 1, 2021

@Gustry I have launch phpstan locally with lizmap and i have same errors

@pdrillin
Copy link
Contributor Author

pdrillin commented Feb 1, 2021

@Gustry I think that it is necessary to define the variables coming from other projects upstream in a config file to be able to use phpstan correctly, but this file can become very long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ajouter les actions de contrôle de qualité du code

2 participants