Improvements in arrangement processing#168
Merged
Merged
Conversation
than half repair radius
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 Fixes roof-ground bowties
after - before:

ElevationProviderintoArrangementDissolver.in_footprint = falseandis_ground = true.is_footprint_holeso floor holes are preserved.ArrangementExtruderfrom extruding roof faces below terrain, avoiding bowtie/invalid geometry.2 Prevent non manifold edges in extrusion
before - after:

Fix non-manifold extrusion edges caused by alternating roof heights at high-valence arrangement vertices.
3 Prevent self intersecting polygons
This in some cases also led to holes in the adjacent wall faces. Fixed using the same approach as for 2, ie. extends the criteria to detect problematic junctions by counting how many times the same face is incident, and joins the repair area in that same face.
before - after:
