Sync Fork #20
Open
Sync Fork #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (#67946) * Use PaneHeaderInput on NewSegmentHeader * Apply segment name on content change
* browser params * array options
…Question (#67282) * Allow passing arrays of string as sqlInitialParameters in InteractiveQuestion * nit * better assertion * pass all initial sql params as is
#67376) * fix: make dashboard header use container query * use named container everywhere * fix syntax * rename and extract to other class
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com>
…ink to admin settings (#67925)
* fix: ellipsis breadcrumb shows gray background in Dark Mode * refactor: use `metabase/ui` in `CollectionBreadcrumbs`
* Fix heading level for multi-tenant strategy section * Correct 'Admin setting' to 'Admin settings' Updated references from 'Admin setting' to 'Admin settings' for consistency throughout the document. * more edits * typos
* Replace data picker image, add a line about search * Optimized 1 images, saved -360 bytes (-1.1% smaller) * Fix screenshot and description to talk about v58 * Incorporate bot suggestion --------- Co-authored-by: Metabase Automation <github-automation@metabase.com>
* AI exploration section * Optimized 2 images, saved 221.4 KB (51.0% smaller) * fix the heading link * Update docs/ai/metabot.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * Update docs/ai/settings.md Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com> * few edits * typo --------- Co-authored-by: Metabase Automation <github-automation@metabase.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
* fix translation docs * comment * sdk * data * cleanup
We can't hydrate unbounded collections of cards with the can_run_adhoc_query hydration since it linearly adds db queries to the request. Users with > 10000k can have severe CPU/memory issues processing this.
* fix: make sure we don't sync unchanged collections * fixup! bad test
…rop the broken dependencies page for now (#68008) * wip * wip * wip * wip * wip * Filters * wip * tests * Fixes * wip * Add e2e test * wip * comment * wip initial personal coll filter * allow deleting personal collections * used by * whitespace * lint --------- Co-authored-by: Riley Thompson <rileythompson99@gmail.com>
* tweak tree table column widths * tweak widths * specs
* fix: ensure common python library is always defined * chore: e2e test * fix: empty rollback * fix: empty source * fix: text
* Forcing overflow policy on ChartTypeDropdown * tpyo * refactoring to enable testing this with loki * fixed story * loki * screenshot * removed useless unit test
Fixes #68578 This issue is not about the stack overflow per-se but blowing up on a string includes: ```javascript { "app": "metabase", "time": "2026-01-22T12:08:53.660601485Z", "stream": "stderr", "app_version": "v1.57.10-X01", "message": "Exception in thread \"Thread-41\" java.lang.NullPointerException: Cannot invoke \"Object.toString()\" because \"s\" is null at clojure.string$includes_QMARK_.invokeStatic(string.clj:377) at clojure.string$includes_QMARK_.invoke(string.clj:373) at metabase.app_db.cluster_lock$retryable_QMARK_.invokeStatic(cluster_lock.clj:27) at metabase.app_db.cluster_lock$retryable_QMARK_.invoke(cluster_lock.clj:19) at metabase.app_db.cluster_lock$do_with_cluster_lock.invokeStatic(cluster_lock.clj:87) at metabase.app_db.cluster_lock$do_with_cluster_lock.invoke(cluster_lock.clj:65) at metabase.app_db.cluster_lock$do_with_cluster_lock.invokeStatic(cluster_lock.clj:79) at metabase.app_db.cluster_lock$do_with_cluster_lock.invoke(cluster_lock.clj:65) at metabase.search.task.search_index$init_BANG_.invokeStatic(search_index.clj:36) at metabase.search.task.search_index$init_BANG_.invoke(search_index.clj:32) at clojure.lang.AFn.run(AFn.java:22) at java.base/java.lang.Thread.run(Unknown Source)", "namespace": "hosting-eb9b3875e12d465a", "container": "metabase", "cluster": "metabase-1", "_p": "F" } ``` The error message itself comes from a stackoverflow which perhaps does not have a message? Either way, it's possible for this to be missing so be a bit defensive
Co-authored-by: Claude Code[bot] <noreply@anthropic.com> Co-authored-by: Brad Anderson <brad@metabase.com>
* revert to 0.8.4 * disable test
* Hoist macaw impl from query analyzer * Use macaw-opts in bigquery module * Use macaw-options in sqlserver * Use macaw-options in sql driver * Remove require * Comment * Test * Update test * Update macaw version * Best effort support for bigquery * Make test driver specific * Remove final-not-reserved * Not allowed on clickhouse only * Clickhouse exception test * best effort opts on api * Remove final-non-reserved * Remove requires * driver.u/parsed-query * Use parsed-query * parsed-query * ch test * throw * Lint against incorrect Macaw usage (#68568) * Remove now unused function * Shutdown loud exceptions for now * Shutdown ch test * Update test --------- Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
* fix: flakey ec keypair test * fixup! do crypto in a delay
* feat: support remote-syncing measures Add remote-sync support for measures, following the same pattern as segments: - Add :model/Measure spec to remote-sync-specs with hybrid identity, parent-table eligibility, and event tracking - Update measure permissions to check remote-sync/table-editable? for can-write? and can-create? (replacing superuser-only derive) - Add batched hydration for :can_write on measures - Add measures to serdes/descendants for Table so they export with parent - Add tests for measure import/export tracking in impl_test.clj On the Frontend creates a new data-driven approach to setting up the middleware listener for changes that cause us to refresh dirty-state. * fixup! typecheck
) Closes QUE-2984. Adds an event handler for when a DWH sync is completed, which checks all its tables and fields for their latest update times, and re-analyzes all cards which depend on tables updated since the last analysis.
* Fix SQL editor scrolling on Transform pages * Fix e2e test for question editor * Fix python transform scrolling * Fix lint * Fix view-only transform content height
* fix(UXW-2752): remove unwanted padding on data structure fields tab group * fix(UXW-2707): remove double border on job transforms section * feat(UXW-2718): add horizontal layout for schedule controls * feat(UXW-2709): fix spacing in the segments empty state * fix(UXW-2780): long text overflow in user input * fix(UXW-2710): set proper placeholder text on empty python library first load * feat(UXW-2767): rename 'New collection' to 'Transform folder' * refactor: blow grid & use `Ellipsified` instead
* feat: create library empty state * refactor: use new designs * refactor: fix library creation * fix: paper shadow * fix: e2e
) Closes DEV-1289 ### Description Within the last day or two, `metabase.query-processor-test.remapping-test/self-referencing-test` began failing on MySQL Latest. I hypothesize this has to do with the [latest release](https://dev.mysql.com/doc/relnotes/mysql/9.6/en/news-9-6-0.html) fixing an unknown bug around batch inserts in InnoDB and the deprecation of a recusive [sic] fk-related flag. The error is thrown not in the test conditions, but in the test setup -- MySQL apparently now checks foreign key constraints row-per-row even on a batch insert. This adds a flag that the test can set which changes the test data-loading behavior to disable the FK check before insertion and re-enable it after.
* Read-only: Adjust transform header menu options / Remove edit definition button / Run tab updates * Make Settings tab read-only * fix remote sync setup in e2e test * Do not allow creating a new transform * Make Python library not editable * Hide edit definition in mbql transform view page * Fix e2e * Group e2e tests to improve performance
The existing transform dependencies code only worked with query-based transforms (mbql or native). This extends that code to work with python transforms as well.
fix position of buttons for native query editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
For those employed by Metabase: if you are merging into master, please add either a
backportor ano-backportlabelto this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this
PR?
in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not
apply to you, and the label will be taken care of by your reviewer.
Closes https://github.com/metabase/metabase/issues/[issue_number]
Description
Describe the overall approach and the problem being solved.
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist