[codex] Support pretty rendering for Responses API inputs#5
Merged
alexanderkreidich merged 1 commit intoApr 21, 2026
Merged
Conversation
|
@claude review |
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48993f613c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
48993f6 to
d12ca9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This teaches the OpenAI ChatML adapter to recognize and normalize OpenAI Responses API request payloads that use
inputinstead ofmessages, including requests with tool definitions.It also excludes the raw
inputfield fromadditionalInputso the conversation is not duplicated in the pretty view, and adds coverage for Responses-style requests plus an embedding payload guard.Why
GPT subscription traffic is being logged in Responses API request shape, while the existing pretty renderer only recognized chat-completions style
messagesand Responses output payloads. As a result, request-side pretty rendering showed nothing useful for those rows.Impact
Responses API requests with
inputshould render as ChatML in the Langfuse pretty view instead of falling back to opaque JSON. Embedding-style payloads are intentionally not reclassified as chat.Root cause
The adapter detected
messagesandoutput, but not request payloads shaped like{ input: ... }, which is what the GPT subscription path emits.Validation
additionalInputexcludesinputgit diff --checkNotes
I did not run the full TypeScript/Vitest suite in this environment because the required package manager and dependencies were not available locally.