Add sendDataModel sync, catalog ID, and theme support (#8)#18
Merged
Conversation
Echo the surface data model in client→server envelopes when sendDataModel is true, thread theme from createSurface through to surface state, and acknowledge catalogId storage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendDataModel: trueon a surface, the client now echoes the data model in theA2UIClientMessageenvelope with every action POST. ThedataModelfield is omitted when the flag is false or data is null (JsonIgnoreCondition.WhenWritingDefault).themeproperty fromcreateSurfacemessages is now threaded throughMessageDispatcher→SurfaceManager→A2UISurfaceState(was silently dropped before). Server-sideSurfaceBuilderandA2UIStreamWriteralso support theme.Test plan
SendActionAsync_IncludesDataModel_WhenSendDataModelTrue— verifies data model in envelopeSendActionAsync_OmitsDataModel_WhenSendDataModelFalse— verifies omissionCreateSurface_StoresTheme— verifies theme stored on surface stateCreateSurface_NullTheme_StoresNull— verifies null theme handlingDispatch_CreateSurface_PassesTheme— verifies dispatcher threads theme throughEnvelope_HasExactlyTwoTopLevelPropertiesstill passes (dataModel omitted when null)🤖 Generated with Claude Code