Skip to content

Add support blackwidow v4 x#60

Open
capraztarik wants to merge 23 commits into
1kc:masterfrom
capraztarik:add_support_blackwidowV4X
Open

Add support blackwidow v4 x#60
capraztarik wants to merge 23 commits into
1kc:masterfrom
capraztarik:add_support_blackwidowV4X

Conversation

@capraztarik
Copy link
Copy Markdown

No description provided.

stickoking and others added 23 commits February 3, 2024 23:00
…75%_support

Add Blackwidow v4 75% support
…75%_support

Dev/add razer blackwidow v4 75% support
Added Support for Razer Ornata V3X Keyboard
…oking

Add support for Razer BlackWidow V4 Pro keyboard
Copy link
Copy Markdown
Collaborator

@edualm edualm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

Also, this MR seems to have more changes than just Blackwidow V4 X. Can you update the description/title?

Thanks!

Comment thread src/lib/razerdevice.c
}

kReturn = (*dev)->USBDeviceOpen(dev);
kReturn = (*dev)->USBDeviceOpenSeize(dev);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the change to USBDeviceOpenSeize needed?

Comment thread src/lib/razerdevice.c
}

kReturn = (*dev)->USBDeviceOpen(dev);
kReturn = (*dev)->USBDeviceOpenSeize(dev);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the change to USBDeviceOpenSeize needed?

Comment thread README.md
@@ -1,5 +1,8 @@
# librazermacos

### Important Note
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted.

Comment thread README.md

## razer-macos frontend
[razer-macos](https://github.com/1kc/razer-macos/) does not actually build `librazermacos.so`, instead the drivers are built by [binding.gyp](https://github.com/1kc/razer-macos/blob/master/binding.gyp).
[razer-macos](https://github.com/stickoking/librazermacos) does not actually build `librazermacos.so`, instead the drivers are built by [binding.gyp](https://github.com/1kc/razer-macos/blob/master/binding.gyp).
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants