Fix issue with blazeface when img is square#295
Open
dcetin wants to merge 1 commit into1adrianb:masterfrom
Open
Fix issue with blazeface when img is square#295dcetin wants to merge 1 commit into1adrianb:masterfrom
dcetin wants to merge 1 commit into1adrianb:masterfrom
Conversation
|
Stumbled across this issue today and the fix worked as intended, thanks @dcetin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's error-prone to center-crop and resize when we only need to do a resize. It somehow messes with the dimensions due to numbers rounding off and rescaled img is of size 128 to 127 instead of a square, which fails the assertion downstream. This could be a issue bigger than the example I presented here though, might need to add a few more test to it to make sure whether it only occurs on square images or the non-square images might also need a fix for rounding-off errors.
Script I ran:
Example image I used: https://images.pexels.com/photos/3042160/pexels-photo-3042160.jpeg
Error I got: