feat: add optional smithay-clipboard backend for Wayland clipboard support#209
Open
proletarius101 wants to merge 1 commit into1Password:masterfrom
Open
feat: add optional smithay-clipboard backend for Wayland clipboard support#209proletarius101 wants to merge 1 commit into1Password:masterfrom
proletarius101 wants to merge 1 commit into1Password:masterfrom
Conversation
…pport - Introduced a new feature `smithay-clipboard` that utilizes the core Wayland `wl_data_device` APIs. This is especially useful to support window compositors like Mutter for GNOME - Implemented a new `Clipboard` struct in the `smithay` module to handle clipboard operations. - Added `init_wayland_display` function to initialize the Wayland display pointer for the smithay backend. - Updated `Cargo.toml` and `Cargo.lock` to include `smithay-clipboard` and its dependencies. - Created an example `smithay_daemonize.rs` demonstrating the usage of the new backend. - Enhanced README with details on the limitations and usage of the `smithay-clipboard` feature. - Updated existing clipboard handling logic to support the new backend while maintaining compatibility with previous implementations.
Member
|
Hi there, thanks for the PR. My understanding of the core Wayland clipboard protocols is that it requires input events to be passed from the compositor into the application receiving those focused user events, which can then perform clipboard operations with the "tokens" available. Does Smithay abstract that away using some internal global state? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smithay-clipboardthat utilizes the core Waylandwl_data_deviceAPIs. This is especially useful to support window compositors like Mutter for GNOMEClipboardstruct in thesmithaymodule to handle clipboard operations.init_wayland_displayfunction to initialize the Wayland display pointer for the smithay backend.Cargo.tomlandCargo.lockto includesmithay-clipboardand its dependencies.smithay_daemonize.rsdemonstrating the usage of the new backend.smithay-clipboardfeature.Related: flathub/me.proton.Pass#37 bitwarden/clients#13431