Skip to content

Conversation

@yeqbfgxjiq
Copy link
Contributor

It works. Currently it's only syncing to the Redemptions overview.md doc, but we can add more as we get the other apps ready. Note: every time we want the docs to be updated on the website we just have to run the publish script again, and now built into publishing it'll fetch the latest docs from wherever the sync script is pointed to.

@yeqbfgxjiq yeqbfgxjiq requested a review from lkngtn July 24, 2019 03:11
@yeqbfgxjiq yeqbfgxjiq mentioned this pull request Jul 24, 2019
@lkngtn
Copy link
Member

lkngtn commented Jul 31, 2019

I tried to preview this locally, but had trouble getting it to run. yarn start fails with the following:

$ npm run clean:docs && npm run sync:dandelion-apps

> @ clean:docs /Users/luke/repos/1hive/website/website
> rm -r ../docs/sync/*

rm: ../docs/sync/*: No such file or directory
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ clean:docs: `rm -r ../docs/sync/*`
npm ERR! Exit status 1

@lkngtn
Copy link
Member

lkngtn commented Jul 31, 2019

using the -f flag will resolve the error, but the redemptions file also doesn't seem to be syncing.

Copy link
Member

@lkngtn lkngtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to get this to work, it doesn't seem the sync function is syncing files correctly, so the redemptions page is missing/not-updated to the file in the redemptions repo.

lkngtn and others added 11 commits July 31, 2019 14:48
removed extra package.json in root dir
Revive dead links in "Roles and Responsibilities"
fixed broken links in dandelion org overview page
You don't need to make any changes to view locally anymore `yarn start` should just work, and not changing it each time for deployments seems simpler/safer.
Fix broken link to "Projects and Tasks"
@yeqbfgxjiq
Copy link
Contributor Author

yeqbfgxjiq commented Aug 5, 2019

Hmmm interesting. It totally works for multiple repos/sync files and I've deployed it on multiple Docusauruses for multiple projects. It might be an error where if the docs /sync folder is empty, it technically can't be cleaned so you need to have some placeholder files in there for the thing to work. I'll check it out now to get it working

EDIT: got it working! There was something wrong with the sync util, so I swapped it out for the latest one I've been using and it's good to go :) Also incorporated the -rf and .gitignore suggestions

@yeqbfgxjiq
Copy link
Contributor Author

@lkngtn marked the change requests as resolved because I added the fixes to the PRs, but now that I think about it are you supposed to close those or am I? lol

@yeqbfgxjiq
Copy link
Contributor Author

@lkngtn last time I checked this was all working on my machine. Was there anything more you wanted to review or should I go ahead and merge it all in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants