fix: address issues #7, #8, #9 (docs, user interaction, skill guidelines)#10
Merged
Hidden character warning
The head ref may contain hidden characters: "feature/\u4fee\u6539issues"
Conversation
- #7: Replace text architecture diagram in README with Mermaid-generated SVG - #8: Add user interaction prompts in skills (agent selection during setup, online/local mode before drawing); qualify desktop-only instructions - #9: Add Skill Development Guidelines to AGENTS.md to prevent test-set pollution (construction-type-specific residue, cross-type verification, clean commits) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
|
@123pc 你好，此 PR 修复了仓库中 3 个开放的 issues：
请审核，谢谢！ |
123pc
approved these changes
May 23, 2026
123pc
left a comment
123pc
left a comment
Owner
There was a problem hiding this comment.
Reviewed the changed docs and skill instructions. Verified the setup skill's new --agent flow matches scripts/setup_geogebra_mcp.py, checked the README architecture SVG reference and parsed docs/architecture.svg as valid XML, and ran the stated automated tests locally:
- python -m pytest: 64 passed
- npm test: 27 passed
The remaining manual checklist items are reasonable documentation/runtime checks, and I did not find blockers in the PR changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md中的文本架构图替换为 Mermaid 生成的 SVG 图片，源码docs/architecture.mmd保留在版本控制中便于后续编辑geogebra-setup技能：安装前先用自然语言询问用户要配置哪个 agent（Claude Code / Codex / 两者）geogebra-master技能：绘图前询问用户使用在线 CDN 还是离线 bundle 模式AGENTS.md添加 Skill Development Guidelines，防止技能对特定构造类型过拟合Test plan
🤖 Generated with Claude Code