Skip to content

refactor: simplify function definition for resolve_provider_and_model#134

Merged
Iamsdt merged 1 commit into
mainfrom
fix/clearnup
Jun 13, 2026
Merged

refactor: simplify function definition for resolve_provider_and_model#134
Iamsdt merged 1 commit into
mainfrom
fix/clearnup

Conversation

@Iamsdt

@Iamsdt Iamsdt commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

This pull request focuses on improving test reliability and code style in the codebase. The most significant changes ensure that environment variables do not cause nondeterministic behavior in tests, and unnecessary dependencies are removed for cleaner test files.

Test environment reliability:

  • The test setup (setup_test_environment in tests/conftest.py) now explicitly unsets the GOOGLE_GENAI_USE_VERTEXAI environment variable to prevent accidental inheritance from developer environments. This ensures deterministic provider selection in tests and avoids unintended use of Vertex AI unless explicitly specified.

Test code cleanup:

  • Removed the dotenv dependency and its usage from tests/normal_tests/test_custom_state_comprehensive.py, as environment variable loading is now handled centrally in the test setup.

Code style and formatting:

  • Minor formatting change to the resolve_provider_and_model function signature in agentflow/core/llm/client_factory.py for consistency and readability.

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Iamsdt Iamsdt merged commit 7eea276 into main Jun 13, 2026
6 checks passed
@Iamsdt Iamsdt deleted the fix/clearnup branch June 13, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant