refactor: simplify function definition for resolve_provider_and_model#134
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving test reliability and code style in the codebase. The most significant changes ensure that environment variables do not cause nondeterministic behavior in tests, and unnecessary dependencies are removed for cleaner test files.
Test environment reliability:
setup_test_environmentintests/conftest.py) now explicitly unsets theGOOGLE_GENAI_USE_VERTEXAIenvironment variable to prevent accidental inheritance from developer environments. This ensures deterministic provider selection in tests and avoids unintended use of Vertex AI unless explicitly specified.Test code cleanup:
dotenvdependency and its usage fromtests/normal_tests/test_custom_state_comprehensive.py, as environment variable loading is now handled centrally in the test setup.Code style and formatting:
resolve_provider_and_modelfunction signature inagentflow/core/llm/client_factory.pyfor consistency and readability.