Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of fallback LLM clients in the agent execution flow, ensuring that configuration for Vertex AI is consistently applied across both primary and fallback clients. The changes make the
use_vertex_aiflag available throughout the agent and its execution mixin, and update the fallback client creation logic to respect this setting.Vertex AI configuration consistency:
use_vertex_aiflag is now stored as an instance variable inMyStateso that it can be accessed when creating fallback clients, ensuring consistent Vertex AI usage.AgentExecutionMixindeclares theuse_vertex_aiattribute so it can be referenced during fallback client creation, even though it is only set by the main agent._call_llm_with_retry, the code now passes theuse_vertex_aiflag to_create_client, ensuring fallback clients honor the same Vertex AI selection as the primary client.Fallback client creation improvements:
_call_llm_with_retryis updated to always pass the correctbase_url(previously could beNone), improving consistency in client configuration.