Skip to content

fix: add active icon styling to link icon#168

Closed
arpitv96171 wants to merge 2 commits into
10play:mainfrom
esan-tech-india:main
Closed

fix: add active icon styling to link icon#168
arpitv96171 wants to merge 2 commits into
10play:mainfrom
esan-tech-india:main

Conversation

@arpitv96171

Copy link
Copy Markdown
Contributor

Link bar link button container has active styling but the icon itself lacked the active styling.
This PR adds the active styling to the link button in EditLinkBar.tsx

@GuySerfaty GuySerfaty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @17Amir17 please take a look and merge

@GuySerfaty GuySerfaty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait commit should follow the commit message convention
https://github.com/10play/10tap-editor/blob/main/CONTRIBUTING.md#commit-message-convention

@17Amir17

Copy link
Copy Markdown
Collaborator

@arpitv96171 Thanks for the pr!

As @GuySerfaty mentioned you just need to change the commit message to something like fix: active icon styling on link icon

@arpitv96171 arpitv96171 changed the title Add active icon styling to link icon fix: add active icon styling to link icon Jul 28, 2024
@arpitv96171

Copy link
Copy Markdown
Contributor Author

@GuySerfaty will changing the PR title work? Or should I create another PR or add another commit with new commit message?

@17Amir17

Copy link
Copy Markdown
Collaborator

@arpitv96171 you can rebase and force push with a new message - we cannot merge without these in the commit message
Opening a new pr with the correct commit message will work too

@arpitv96171

Copy link
Copy Markdown
Contributor Author

new PR: #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants