fix: add active icon styling to link icon#168
Conversation
GuySerfaty
left a comment
There was a problem hiding this comment.
Looks good to me, @17Amir17 please take a look and merge
GuySerfaty
left a comment
There was a problem hiding this comment.
oh wait commit should follow the commit message convention
https://github.com/10play/10tap-editor/blob/main/CONTRIBUTING.md#commit-message-convention
|
@arpitv96171 Thanks for the pr! As @GuySerfaty mentioned you just need to change the commit message to something like |
|
@GuySerfaty will changing the PR title work? Or should I create another PR or add another commit with new commit message? |
|
@arpitv96171 you can rebase and force push with a new message - we cannot merge without these in the commit message |
|
new PR: #172 |
Link bar link button container has active styling but the icon itself lacked the active styling.
This PR adds the active styling to the link button in
EditLinkBar.tsx