gevent_zmq: import enums from pyzmq >= 23.0.0 #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With pyzmq 23.0.0, constants were changed to enums and moved to the constants module. Attempt to import all globals from it into our zmq wrapper. Closes: 0rpc#251 Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
Contributor
Author
Contributor
Author
|
@bombela would be nice to get that one in if there are no objections |
Member
|
Will do within the week.
…On Tue, Jan 7, 2025, 09:06 Cedric Hombourger ***@***.***> wrote:
@bombela <https://github.com/bombela> would be nice to get that one in if
there are no objections
—
Reply to this email directly, view it on GitHub
<#252 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUZDE7EBHU3MELRW3QOP32JODITAVCNFSM6AAAAABUXFDX76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUGYZDMMRUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Sorry for delay in literal years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With pyzmq 23.0.0, constants were changed to enums and moved to the
constants module. Attempt to import all globals from it into our zmq
wrapper.
Closes: #251
Signed-off-by: Cedric Hombourger cedric.hombourger@siemens.com