🎨 Palette: Add ARIA roles and spacebar support to modal anchor buttons#138
Conversation
Added `role="button"` and `aria-haspopup="dialog"` to `#sitrep-btn` anchors across HTML files. Added a `keydown` listener in `modal.js` to trigger on Spacebar, bringing full keyboard accessibility to these custom trigger elements. Updated `.Jules/palette.md` with learnings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
role="button"andaria-haspopup="dialog"to the "OSINT" anchor tags (#sitrep-btn) acrossconcepts.html,contact.html, andproducts.html. Also updatedmodal.jsto listen for theSpacebarkey down event on these buttons, callinge.preventDefault()to stop page scrolling and triggering the modal open action. Added a learning journal entry about this process in.Jules/palette.md.🎯 Why: When using
<a>tags withhref="#"as interactive elements (like opening a modal), they lack the semantic meaning of a button. Screen readers will read them as links, confusing users about the expected interaction. Furthermore, native links only trigger onEnter, whereas users expect buttons to trigger on bothEnterandSpacebar.📸 Before/After: Visually identical. A screenshot of the modal triggered via spacebar has been captured for testing.
♿ Accessibility: This change directly addresses a significant keyboard and screen reader accessibility barrier, ensuring the "OSINT" triggers behave identically to native
<button>elements for all users.PR created automatically by Jules for task 4026229093642811545 started by @0m364